pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Masahiko Sawada <msawada@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Honor run_as_owner option in tablesync worker.
Date: Fri, 09 Jun 2023 01:44:12 +0000
Message-ID: <E1q7RAi-000qlR-0s@gemulon.postgresql.org> (raw)

Honor run_as_owner option in tablesync worker.

Commit 482675987 introduced "run_as_owner" subscription option so that
subscription runs with either the permissions of the subscription
owner or the permission of the table owner. However, tablesync workers
did not use this option for the initial data copy.

With this change, tablesync workers run with appropriate permissions
based on "run_as_owner" option.

Ajin Cherian, with changes and regression tests added by me.

Reported-By: Amit Kapila
Author: Ajin Cherian, Masahiko Sawada
Reviewed-by: Ajin Cherian, Amit Kapila
Discussion: https://postgr.es/m/CAA4eK1L=qzRHPEn+qeMoKQGFBzqGoLBzt_ov0A89iFFiut+ppA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/a83edeaf684a70da02fa2bce8b7e3aefa3f906f5

Modified Files
--------------
src/backend/replication/logical/tablesync.c       | 64 ++++++++++++++---------
src/test/subscription/t/033_run_as_table_owner.pl | 38 +++++++++++++-
2 files changed, 75 insertions(+), 27 deletions(-)



Message-ID: <E1q7RAi-000qlR-0s@gemulon.postgresql.org>
Permalink:  ../E1q7RAi-000qlR-0s@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1q7RAi-000qlR-0s@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: msawada@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Honor run_as_owner option in tablesync worker.
  In-Reply-To: <E1q7RAi-000qlR-0s@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox