From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: hstore: Tighten key/value parsing check for whitespaces
Date: Mon, 12 Jun 2023 00:15:28 +0000
Message-ID: <E1q8VDT-001Kjc-OZ@gemulon.postgresql.org> (raw)
hstore: Tighten key/value parsing check for whitespaces
isspace() can be locale-sensitive depending on the platform, causing
hstore to consider as whitespaces characters it should not see as such.
For example, U+0105, being decoded as 0xC4 0x85 in UTF-8, would be
discarded from the input given.
This problem is similar to 9ae2661, though it was missed that hstore
can also manipulate non-ASCII inputs, so replace the existing isspace()
calls with scanner_isspace().
This problem exists for a long time, so backpatch all the way down.
Author: Evan Jones
Discussion: https://postgr.es/m/CA+HWA9awUW0+RV_gO9r1ABZwGoZxPztcJxPy8vMFSTbTfi4jig@mail.gmail.com
Backpatch-through: 11
Branch
------
REL_14_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/e0e6829459b0e0566dc4493675522afb69d39f36
Modified Files
--------------
contrib/hstore/Makefile | 2 +-
contrib/hstore/expected/hstore_utf8.out | 36 +++++++++++++++++++++++++++++++
contrib/hstore/expected/hstore_utf8_1.out | 8 +++++++
contrib/hstore/hstore_io.c | 9 ++++----
contrib/hstore/sql/hstore_utf8.sql | 19 ++++++++++++++++
5 files changed, 69 insertions(+), 5 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: hstore: Tighten key/value parsing check for whitespaces
In-Reply-To: <E1q8VDT-001Kjc-OZ@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox