pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: hstore: Tighten key/value parsing check for whitespaces
6+ messages / 1 participants
[nested] [flat]

* pgsql: hstore: Tighten key/value parsing check for whitespaces
@ 2023-06-12 00:15  Michael Paquier <michael@paquier.xyz>
  0 siblings, 0 replies; 6+ messages in thread

From: Michael Paquier @ 2023-06-12 00:15 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

hstore: Tighten key/value parsing check for whitespaces

isspace() can be locale-sensitive depending on the platform, causing
hstore to consider as whitespaces characters it should not see as such.
For example, U+0105, being decoded as 0xC4 0x85 in UTF-8, would be
discarded from the input given.

This problem is similar to 9ae2661, though it was missed that hstore
can also manipulate non-ASCII inputs, so replace the existing isspace()
calls with scanner_isspace().

This problem exists for a long time, so backpatch all the way down.

Author: Evan Jones
Discussion: https://postgr.es/m/CA+HWA9awUW0+RV_gO9r1ABZwGoZxPztcJxPy8vMFSTbTfi4jig@mail.gmail.com
Backpatch-through: 11

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/3a5222a432beeb980208a2d9abeb517412f4d469

Modified Files
--------------
contrib/hstore/Makefile                   |  2 +-
contrib/hstore/expected/hstore_utf8.out   | 36 +++++++++++++++++++++++++++++++
contrib/hstore/expected/hstore_utf8_1.out |  8 +++++++
contrib/hstore/hstore_io.c                |  9 ++++----
contrib/hstore/sql/hstore_utf8.sql        | 19 ++++++++++++++++
5 files changed, 69 insertions(+), 5 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: hstore: Tighten key/value parsing check for whitespaces
@ 2023-06-12 00:15  Michael Paquier <michael@paquier.xyz>
  0 siblings, 0 replies; 6+ messages in thread

From: Michael Paquier @ 2023-06-12 00:15 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

hstore: Tighten key/value parsing check for whitespaces

isspace() can be locale-sensitive depending on the platform, causing
hstore to consider as whitespaces characters it should not see as such.
For example, U+0105, being decoded as 0xC4 0x85 in UTF-8, would be
discarded from the input given.

This problem is similar to 9ae2661, though it was missed that hstore
can also manipulate non-ASCII inputs, so replace the existing isspace()
calls with scanner_isspace().

This problem exists for a long time, so backpatch all the way down.

Author: Evan Jones
Discussion: https://postgr.es/m/CA+HWA9awUW0+RV_gO9r1ABZwGoZxPztcJxPy8vMFSTbTfi4jig@mail.gmail.com
Backpatch-through: 11

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/bbfc26d861fa67fa78921b9f24cff253d6db3635

Modified Files
--------------
contrib/hstore/Makefile                   |  2 +-
contrib/hstore/expected/hstore_utf8.out   | 36 +++++++++++++++++++++++++++++++
contrib/hstore/expected/hstore_utf8_1.out |  8 +++++++
contrib/hstore/hstore_io.c                |  9 ++++----
contrib/hstore/sql/hstore_utf8.sql        | 19 ++++++++++++++++
5 files changed, 69 insertions(+), 5 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: hstore: Tighten key/value parsing check for whitespaces
@ 2023-06-12 00:15  Michael Paquier <michael@paquier.xyz>
  0 siblings, 0 replies; 6+ messages in thread

From: Michael Paquier @ 2023-06-12 00:15 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

hstore: Tighten key/value parsing check for whitespaces

isspace() can be locale-sensitive depending on the platform, causing
hstore to consider as whitespaces characters it should not see as such.
For example, U+0105, being decoded as 0xC4 0x85 in UTF-8, would be
discarded from the input given.

This problem is similar to 9ae2661, though it was missed that hstore
can also manipulate non-ASCII inputs, so replace the existing isspace()
calls with scanner_isspace().

This problem exists for a long time, so backpatch all the way down.

Author: Evan Jones
Discussion: https://postgr.es/m/CA+HWA9awUW0+RV_gO9r1ABZwGoZxPztcJxPy8vMFSTbTfi4jig@mail.gmail.com
Backpatch-through: 11

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/e0e6829459b0e0566dc4493675522afb69d39f36

Modified Files
--------------
contrib/hstore/Makefile                   |  2 +-
contrib/hstore/expected/hstore_utf8.out   | 36 +++++++++++++++++++++++++++++++
contrib/hstore/expected/hstore_utf8_1.out |  8 +++++++
contrib/hstore/hstore_io.c                |  9 ++++----
contrib/hstore/sql/hstore_utf8.sql        | 19 ++++++++++++++++
5 files changed, 69 insertions(+), 5 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: hstore: Tighten key/value parsing check for whitespaces
@ 2023-06-12 00:15  Michael Paquier <michael@paquier.xyz>
  0 siblings, 0 replies; 6+ messages in thread

From: Michael Paquier @ 2023-06-12 00:15 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

hstore: Tighten key/value parsing check for whitespaces

isspace() can be locale-sensitive depending on the platform, causing
hstore to consider as whitespaces characters it should not see as such.
For example, U+0105, being decoded as 0xC4 0x85 in UTF-8, would be
discarded from the input given.

This problem is similar to 9ae2661, though it was missed that hstore
can also manipulate non-ASCII inputs, so replace the existing isspace()
calls with scanner_isspace().

This problem exists for a long time, so backpatch all the way down.

Author: Evan Jones
Discussion: https://postgr.es/m/CA+HWA9awUW0+RV_gO9r1ABZwGoZxPztcJxPy8vMFSTbTfi4jig@mail.gmail.com
Backpatch-through: 11

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/edf1de65e529e85aa1aba15260339becbfe5d598

Modified Files
--------------
contrib/hstore/Makefile                   |  2 +-
contrib/hstore/expected/hstore_utf8.out   | 36 +++++++++++++++++++++++++++++++
contrib/hstore/expected/hstore_utf8_1.out |  8 +++++++
contrib/hstore/hstore_io.c                |  9 ++++----
contrib/hstore/sql/hstore_utf8.sql        | 19 ++++++++++++++++
5 files changed, 69 insertions(+), 5 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: hstore: Tighten key/value parsing check for whitespaces
@ 2023-06-12 00:15  Michael Paquier <michael@paquier.xyz>
  0 siblings, 0 replies; 6+ messages in thread

From: Michael Paquier @ 2023-06-12 00:15 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

hstore: Tighten key/value parsing check for whitespaces

isspace() can be locale-sensitive depending on the platform, causing
hstore to consider as whitespaces characters it should not see as such.
For example, U+0105, being decoded as 0xC4 0x85 in UTF-8, would be
discarded from the input given.

This problem is similar to 9ae2661, though it was missed that hstore
can also manipulate non-ASCII inputs, so replace the existing isspace()
calls with scanner_isspace().

This problem exists for a long time, so backpatch all the way down.

Author: Evan Jones
Discussion: https://postgr.es/m/CA+HWA9awUW0+RV_gO9r1ABZwGoZxPztcJxPy8vMFSTbTfi4jig@mail.gmail.com
Backpatch-through: 11

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/78bf0a256d129b517ca6a5fea14586489acea296

Modified Files
--------------
contrib/hstore/Makefile                   |  2 +-
contrib/hstore/expected/hstore_utf8.out   | 36 +++++++++++++++++++++++++++++++
contrib/hstore/expected/hstore_utf8_1.out |  8 +++++++
contrib/hstore/hstore_io.c                |  9 ++++----
contrib/hstore/sql/hstore_utf8.sql        | 19 ++++++++++++++++
5 files changed, 69 insertions(+), 5 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: hstore: Tighten key/value parsing check for whitespaces
@ 2023-06-12 00:15  Michael Paquier <michael@paquier.xyz>
  0 siblings, 0 replies; 6+ messages in thread

From: Michael Paquier @ 2023-06-12 00:15 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

hstore: Tighten key/value parsing check for whitespaces

isspace() can be locale-sensitive depending on the platform, causing
hstore to consider as whitespaces characters it should not see as such.
For example, U+0105, being decoded as 0xC4 0x85 in UTF-8, would be
discarded from the input given.

This problem is similar to 9ae2661, though it was missed that hstore
can also manipulate non-ASCII inputs, so replace the existing isspace()
calls with scanner_isspace().

This problem exists for a long time, so backpatch all the way down.

Author: Evan Jones
Discussion: https://postgr.es/m/CA+HWA9awUW0+RV_gO9r1ABZwGoZxPztcJxPy8vMFSTbTfi4jig@mail.gmail.com
Backpatch-through: 11

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d522b05c8c1c2c430b2c8be795c609f6f4f2ce44

Modified Files
--------------
contrib/hstore/Makefile                   |  2 +-
contrib/hstore/expected/hstore_utf8.out   | 36 +++++++++++++++++++++++++++++++
contrib/hstore/expected/hstore_utf8_1.out |  8 +++++++
contrib/hstore/hstore_io.c                |  9 ++++----
contrib/hstore/meson.build                |  1 +
contrib/hstore/sql/hstore_utf8.sql        | 19 ++++++++++++++++
6 files changed, 70 insertions(+), 5 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread


end of thread, other threads:[~2023-06-12 00:15 UTC | newest]

Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2023-06-12 00:15 pgsql: hstore: Tighten key/value parsing check for whitespaces Michael Paquier <michael@paquier.xyz>
2023-06-12 00:15 pgsql: hstore: Tighten key/value parsing check for whitespaces Michael Paquier <michael@paquier.xyz>
2023-06-12 00:15 pgsql: hstore: Tighten key/value parsing check for whitespaces Michael Paquier <michael@paquier.xyz>
2023-06-12 00:15 pgsql: hstore: Tighten key/value parsing check for whitespaces Michael Paquier <michael@paquier.xyz>
2023-06-12 00:15 pgsql: hstore: Tighten key/value parsing check for whitespaces Michael Paquier <michael@paquier.xyz>
2023-06-12 00:15 pgsql: hstore: Tighten key/value parsing check for whitespaces Michael Paquier <michael@paquier.xyz>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox