pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Accept fractional seconds in jsonpath's datetime() method.
Date: Mon, 12 Jun 2023 14:54:54 +0000
Message-ID: <E1q8iwX-001QGa-Ek@gemulon.postgresql.org> (raw)

Accept fractional seconds in jsonpath's datetime() method.

Commit 927d9abb6 purported to make datetime() accept any string
that could be output for a datetime value by to_jsonb().  But it
overlooked the possibility of fractional seconds being present,
so that cases as simple as to_jsonb(now()) would defeat it.

Fix by adding formats that include ".US" to the list in
executeDateTimeMethod().  (Note that while this is nominally
microseconds, it'll do the right thing for fractions with
fewer than six digits.)

In passing, re-order the list to restore the datatype ordering
specified in its comment.  The violation accidentally did not
break anything; but the next edit might be less lucky, so add
more comments.

Per report from Tim Field.  Back-patch to v13 where datetime()
was added, like the previous patch.

Discussion: https://postgr.es/m/014A028B-5CE6-4FDF-AC24-426CA6FC9CEE@mohiohio.com

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/bd590d1fea1ba9245c791d589eea94d2dbad5a2b

Modified Files
--------------
src/backend/utils/adt/jsonpath_exec.c        | 17 +++++++++++++----
src/test/regress/expected/jsonb_jsonpath.out | 15 +++++++++++++++
src/test/regress/sql/jsonb_jsonpath.sql      |  3 +++
3 files changed, 31 insertions(+), 4 deletions(-)



view thread (4+ messages)  latest in thread

Message-ID: <E1q8iwX-001QGa-Ek@gemulon.postgresql.org>
Permalink:  ../E1q8iwX-001QGa-Ek@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1q8iwX-001QGa-Ek@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Accept fractional seconds in jsonpath's datetime() method.
  In-Reply-To: <E1q8iwX-001QGa-Ek@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox