pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Report stats when replaying XLOG_RUNNING_XACTS
Date: Tue, 13 Jun 2023 03:52:15 +0000
Message-ID: <E1q8v4o-001WKP-US@gemulon.postgresql.org> (raw)

Report stats when replaying XLOG_RUNNING_XACTS

Previously stats in the startup process would only get reported during
shutdown of the startup process. It has been that way for a long time, but
became a lot more noticeable with the new pg_stat_io view, which separates out
IO done by different backend types...

While replaying after every XLOG_RUNNING_XACTS isn't the prettiest approach,
it has the advantage of being quite easy. Given that we're well past feature
freeze...

It's not a problem that we don't report stats more frequently with
wal_level=minimal, in that case stats can't be read before the stats process
has shut down.

Besides the above, this commit also changes pgstat_report_stat() to acquire
the timestamp with GetCurrentTimestamp() instead of
GetCurrentTransactionStopTimestamp().

Thanks to Melih Mutlu, Kyotaro Horiguchi for prototypes of other approaches to
solving this issue.

Reported-by: Fujii Masao <masao.fujii@oss.nttdata.com>
Discussion: https://postgr.es/m/5315aedc-fbca-1556-c5de-dc2e00b23a14@oss.nttdata.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e3cb1a586cef746326eeabf36d103ea1136607f9

Modified Files
--------------
src/backend/storage/ipc/standby.c   |  9 +++++++++
src/backend/utils/activity/pgstat.c | 17 ++++++++++++++---
2 files changed, 23 insertions(+), 3 deletions(-)



Message-ID: <E1q8v4o-001WKP-US@gemulon.postgresql.org>
Permalink:  ../E1q8v4o-001WKP-US@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1q8v4o-001WKP-US@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: andres@anarazel.de, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Report stats when replaying XLOG_RUNNING_XACTS
  In-Reply-To: <E1q8v4o-001WKP-US@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox