pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix "wrong varnullingrels" for Memoize's lateral references, too
Date: Tue, 13 Jun 2023 22:01:44 +0000
Message-ID: <E1q9C59-001er1-PL@gemulon.postgresql.org> (raw)

Fix "wrong varnullingrels" for Memoize's lateral references, too.

The issue fixed in commit bfd332b3f can also bite Memoize plans,
because of the separate copies of lateral reference Vars made
by paraminfo_get_equal_hashops.  Apply the same hacky fix there.

(In passing, clean up shaky grammar in the existing comments
for this function.)

Richard Guo

Discussion: https://postgr.es/m/CAMbWs4-krwk0Wbd6WdufMAupuou_Ua73ijQ4XQCr1Mb5BaVtKQ@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/63e4f13d2a78124c798165814a679b0534db87a5

Modified Files
--------------
src/backend/optimizer/path/joinpath.c | 55 ++++++++++++++++++++++++++++++-----
src/backend/optimizer/plan/setrefs.c  | 10 +++----
src/test/regress/expected/join.out    | 21 +++++++++++++
src/test/regress/sql/join.sql         |  7 +++++
4 files changed, 81 insertions(+), 12 deletions(-)



Message-ID: <E1q9C59-001er1-PL@gemulon.postgresql.org>
Permalink:  ../E1q9C59-001er1-PL@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1q9C59-001er1-PL@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix "wrong varnullingrels" for Memoize's lateral references, too
  In-Reply-To: <E1q9C59-001er1-PL@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox