pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Noah Misch <noah@leadboat.com>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Make parseNodeString() C idiom compatible with Visual Studio 201
Date: Wed, 14 Jun 2023 12:35:40 +0000
Message-ID: <E1q9Piu-001l6H-3Q@gemulon.postgresql.org> (raw)

Make parseNodeString() C idiom compatible with Visual Studio 2015.

Between v15 and now, this function's "else if" chain grew from 252 lines
to 592 lines, exceeding a compiler limit that manifests as "fatal error
C1026: parser stack overflow, program too complex (compiling source file
src/backend/nodes/readfuncs.c)".  Use "if (...)  return ...;" instead.

Reviewed by Tom Lane, Peter Eisentraut and Michael Paquier.  Not all
reviewers endorse this.

Discussion: https://postgr.es/m/20230607185458.GA1334487@rfd.leadboat.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/f9f31aa91f82df863a35354893978e1937863d7c

Modified Files
--------------
src/backend/nodes/gen_node_support.pl |  4 ++--
src/backend/nodes/readfuncs.c         | 12 ++----------
2 files changed, 4 insertions(+), 12 deletions(-)



Message-ID: <E1q9Piu-001l6H-3Q@gemulon.postgresql.org>
Permalink:  ../E1q9Piu-001l6H-3Q@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1q9Piu-001l6H-3Q@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: noah@leadboat.com, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Make parseNodeString() C idiom compatible with Visual Studio 201
  In-Reply-To: <E1q9Piu-001l6H-3Q@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox