From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Don't include outer join relids in lateral_relids bitmapsets.
Date: Tue, 20 Jun 2023 14:30:05 +0000
Message-ID: <E1qBcMu-002jsh-Jv@gemulon.postgresql.org> (raw)
Don't include outer join relids in lateral_relids bitmapsets.
This avoids an assertion failure when outer joins are rearranged
per identity 3. Listing only the baserels from a PlaceHolderVar's
ph_lateral set should be enough to ensure that the required values
are available when we need to compute the PHV --- it's what we
did before inventing nullingrel sets, after all. It's a bit
unsatisfying; but with beta2 hard upon us, there's not time to
look for an aesthetically cleaner fix.
Richard Guo and Tom Lane
Discussion: https://postgr.es/m/CAMbWs48Jcw-NvnxT23WiHP324wG44DvzcH1j4hc0Zn+3sR9cfg@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/efeb12ef0bfef0b5aa966a56bb4dbb1f936bda0c
Modified Files
--------------
src/backend/optimizer/plan/initsplan.c | 16 +++++++++++++---
src/test/regress/expected/join.out | 17 +++++++++++++++++
src/test/regress/sql/join.sql | 7 +++++++
3 files changed, 37 insertions(+), 3 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Don't include outer join relids in lateral_relids bitmapsets.
In-Reply-To: <E1qBcMu-002jsh-Jv@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox