pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Add timeline ID to file names generated with pg_waldump --save-f
Date: Wed, 28 Jun 2023 07:32:20 +0000
Message-ID: <E1qEPf2-000oU8-Li@gemulon.postgresql.org> (raw)

Add timeline ID to file names generated with pg_waldump --save-fullpage

Not including the timeline IDs to the file names generated by pg_waldump
for the individual blocks saved could cause some of these files to be
overwritten when scanning segments across multiple timelines.  Having
this information is also as much useful as the LSNs, to be able to know
from exactly which WAL segment a block is comes from.

While on it, this fixes a few comments in the tests, where the format of
the file was not described as matching with the reality.

Reported-by: Fujii Masao
Reviewed-by: Kyotaro Horiguchi, David Christensen
Discussion: https://postgr.es/m/ZJp921+nITFnvBVS@paquier.xyz

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b381d9637030c163c3b1f8a9d3de51dfc1b4ee58

Modified Files
--------------
doc/src/sgml/ref/pg_waldump.sgml          | 9 ++++++++-
src/bin/pg_waldump/pg_waldump.c           | 3 ++-
src/bin/pg_waldump/t/002_save_fullpage.pl | 9 +++++----
3 files changed, 15 insertions(+), 6 deletions(-)



Message-ID: <E1qEPf2-000oU8-Li@gemulon.postgresql.org>
Permalink:  ../E1qEPf2-000oU8-Li@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qEPf2-000oU8-Li@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Add timeline ID to file names generated with pg_waldump --save-f
  In-Reply-To: <E1qEPf2-000oU8-Li@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox