pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Remove inappropriate raw_expression_tree_walker() code 3+ messages / 1 participants [nested] [flat]
* pgsql: Remove inappropriate raw_expression_tree_walker() code @ 2023-06-29 09:05 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 3+ messages in thread From: Peter Eisentraut @ 2023-06-29 09:05 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Remove inappropriate raw_expression_tree_walker() code It was walking into the ColumnDef->compression field, which is not a node but a string. This code is currently not reachable (because the compression field is only set in situations that don't go through raw_expression_tree_walker()), but if it had been, this could have behaved erratically. Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/6bc7873da1c3e9f1d870fa2d671eb450ea6c9753 Modified Files -------------- src/backend/nodes/nodeFuncs.c | 2 -- 1 file changed, 2 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Remove inappropriate raw_expression_tree_walker() code @ 2023-06-29 09:05 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 3+ messages in thread From: Peter Eisentraut @ 2023-06-29 09:05 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Remove inappropriate raw_expression_tree_walker() code It was walking into the ColumnDef->compression field, which is not a node but a string. This code is currently not reachable (because the compression field is only set in situations that don't go through raw_expression_tree_walker()), but if it had been, this could have behaved erratically. Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/df5dcf41cf01af158d2b833a0ae752e52f5d38e8 Modified Files -------------- src/backend/nodes/nodeFuncs.c | 2 -- 1 file changed, 2 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Remove inappropriate raw_expression_tree_walker() code @ 2023-06-29 09:05 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 3+ messages in thread From: Peter Eisentraut @ 2023-06-29 09:05 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Remove inappropriate raw_expression_tree_walker() code It was walking into the ColumnDef->compression field, which is not a node but a string. This code is currently not reachable (because the compression field is only set in situations that don't go through raw_expression_tree_walker()), but if it had been, this could have behaved erratically. Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/efcf55f8fe00b46198cd34557431c87ce5da8040 Modified Files -------------- src/backend/nodes/nodeFuncs.c | 2 -- 1 file changed, 2 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2023-06-29 09:05 UTC | newest] Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2023-06-29 09:05 pgsql: Remove inappropriate raw_expression_tree_walker() code Peter Eisentraut <peter@eisentraut.org> 2023-06-29 09:05 pgsql: Remove inappropriate raw_expression_tree_walker() code Peter Eisentraut <peter@eisentraut.org> 2023-06-29 09:05 pgsql: Remove inappropriate raw_expression_tree_walker() code Peter Eisentraut <peter@eisentraut.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox