pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove inappropriate raw_expression_tree_walker() code
Date: Thu, 29 Jun 2023 09:05:17 +0000
Message-ID: <E1qEnaX-000zty-DR@gemulon.postgresql.org> (raw)

Remove inappropriate raw_expression_tree_walker() code

It was walking into the ColumnDef->compression field, which is not a
node but a string.  This code is currently not reachable (because the
compression field is only set in situations that don't go through
raw_expression_tree_walker()), but if it had been, this could have
behaved erratically.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/efcf55f8fe00b46198cd34557431c87ce5da8040

Modified Files
--------------
src/backend/nodes/nodeFuncs.c | 2 --
1 file changed, 2 deletions(-)



view thread (3+ messages)

Message-ID: <E1qEnaX-000zty-DR@gemulon.postgresql.org>
Permalink:  ../E1qEnaX-000zty-DR@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qEnaX-000zty-DR@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Remove inappropriate raw_expression_tree_walker() code
  In-Reply-To: <E1qEnaX-000zty-DR@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox