pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix order of operations in ExecEvalFieldStoreDeForm().
Date: Thu, 29 Jun 2023 14:20:11 +0000
Message-ID: <E1qEsVH-00126v-Fi@gemulon.postgresql.org> (raw)

Fix order of operations in ExecEvalFieldStoreDeForm().

If the given composite datum is toasted out-of-line,
DatumGetHeapTupleHeader will perform database accesses to detoast it.
That can invalidate the result of get_cached_rowtype, as documented
(perhaps not plainly enough) in that function's API spec; which leads
to strange errors or crashes when we try to use the TupleDesc to read
the tuple.  In short then, trying to update a field of a composite
column could fail intermittently if the overall column value is wide
enough to require toasting.

We can fix the bug at no cost by just changing the order of
operations, since we don't need the TupleDesc until after detoasting.
(Other callers of get_cached_rowtype appear to get this right already,
so there's only one bug.)

Note that the added regression test case reveals this bug reliably
only with debug_discard_caches/CLOBBER_CACHE_ALWAYS.

Per bug #17994 from Alexander Lakhin.  Sadly, this patch does not fix
the missing-values issue revealed in the bug discussion; we'll need
some more work to cover that.

Discussion: https://postgr.es/m/17994-5c7100b51b4790e9@postgresql.org

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/0789b82a97924cec14f651f678eebc56c09da17f

Modified Files
--------------
src/backend/executor/execExprInterp.c  | 29 +++++++++++++++++------------
src/test/regress/expected/rowtypes.out |  9 +++++++++
src/test/regress/sql/rowtypes.sql      |  5 +++++
3 files changed, 31 insertions(+), 12 deletions(-)



view thread (6+ messages)  latest in thread

Message-ID: <E1qEsVH-00126v-Fi@gemulon.postgresql.org>
Permalink:  ../E1qEsVH-00126v-Fi@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qEsVH-00126v-Fi@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix order of operations in ExecEvalFieldStoreDeForm().
  In-Reply-To: <E1qEsVH-00126v-Fi@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox