pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Use named captures in Catalog::ParseHeader()
Date: Fri, 30 Jun 2023 00:23:25 +0000
Message-ID: <E1qF1v3-0016hV-GR@gemulon.postgresql.org> (raw)

Use named captures in Catalog::ParseHeader()

Using at least perl 5.14 is required since 4c15327, meaning that it is
possible to use named captures and the %+ hash instead of having to
count parenthesis groups manually.

While on it, CATALOG is made more flexible in its handling of
whitespaces for parameter lists (see the addition of \s* in this
case).  The generated postgres.bki remains exactly the same before and
after this commit.

Author: Dagfinn Ilmari Mannsåker
Reviewed-by: John Naylor
Discussion: https://postgr.es/m/87y1l3s7o9.fsf@wibble.ilmari.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/23d8624fe52efff0e1c8a6e809d51671f9f549d6

Modified Files
--------------
src/backend/catalog/Catalog.pm | 85 +++++++++++++++++++++++++-----------------
1 file changed, 50 insertions(+), 35 deletions(-)



Message-ID: <E1qF1v3-0016hV-GR@gemulon.postgresql.org>
Permalink:  ../E1qF1v3-0016hV-GR@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qF1v3-0016hV-GR@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Use named captures in Catalog::ParseHeader()
  In-Reply-To: <E1qF1v3-0016hV-GR@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox