pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tomas Vondra <tomas.vondra@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Minor cleanups in the BRIN code
Date: Sun, 02 Jul 2023 08:21:33 +0000
Message-ID: <E1qFsKr-001UlM-Jn@gemulon.postgresql.org> (raw)

Minor cleanups in the BRIN code

BRIN bloom and minmax-multi opclasses were somewhat inconsistent when
dealing with bool variables, assigning to them Datum values etc. While
not a bug, it makes the code harder to understand, so fix that.

While at it, update an incorrect comment copied to bloom opclass from
minmax, talking about strategies not supported by bloom.

Reviewed-by: Heikki Linnakangas
Discussion: https://postgr.es/m/0e1f3350-c9cf-ab62-43a5-5dae314de89c%40enterprisedb.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/28d03feac386c2c68ffaa47f30e6578591ef5c1b

Modified Files
--------------
src/backend/access/brin/brin_bloom.c        | 15 +++++++++------
src/backend/access/brin/brin_minmax_multi.c | 24 ++++++++++++------------
2 files changed, 21 insertions(+), 18 deletions(-)



Message-ID: <E1qFsKr-001UlM-Jn@gemulon.postgresql.org>
Permalink:  ../E1qFsKr-001UlM-Jn@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qFsKr-001UlM-Jn@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tomas.vondra@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Minor cleanups in the BRIN code
  In-Reply-To: <E1qFsKr-001UlM-Jn@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox