pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Silence "missing contrecord" error. 3+ messages / 1 participants [nested] [flat]
* pgsql: Silence "missing contrecord" error. @ 2023-07-02 23:28 Thomas Munro <tmunro@postgresql.org> 0 siblings, 0 replies; 3+ messages in thread From: Thomas Munro @ 2023-07-02 23:28 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Silence "missing contrecord" error. Commit dd38ff28ad added a new error message "missing contrecord" when we fail to reassemble a record. Unfortunately that caused noisy messages to be logged by pg_waldump at end of segment, and by walsender when asked to shut down on a segment boundary. Remove the new error message, so that this condition signals end-of- WAL without a message. It's arguably a reportable condition that should not be silenced while performing crash recovery, but fixing that without introducing noise in the other cases will require more research. Back-patch to 15. Reported-by: Tomas Vondra <tomas.vondra@enterprisedb.com> Discussion: https://postgr.es/m/6a1df56e-4656-b3ce-4b7a-a9cb41df8189%40enterprisedb.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/4637a6ac0b40fef701ab850de1be547b927c3013 Modified Files -------------- src/backend/access/transam/xlogreader.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Silence "missing contrecord" error. @ 2023-07-02 23:29 Thomas Munro <tmunro@postgresql.org> 0 siblings, 0 replies; 3+ messages in thread From: Thomas Munro @ 2023-07-02 23:29 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Silence "missing contrecord" error. Commit dd38ff28ad added a new error message "missing contrecord" when we fail to reassemble a record. Unfortunately that caused noisy messages to be logged by pg_waldump at end of segment, and by walsender when asked to shut down on a segment boundary. Remove the new error message, so that this condition signals end-of- WAL without a message. It's arguably a reportable condition that should not be silenced while performing crash recovery, but fixing that without introducing noise in the other cases will require more research. Back-patch to 15. Reported-by: Tomas Vondra <tomas.vondra@enterprisedb.com> Discussion: https://postgr.es/m/6a1df56e-4656-b3ce-4b7a-a9cb41df8189%40enterprisedb.com Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/76d5966b3b798cc58025c77164fa944f2b6dd667 Modified Files -------------- src/backend/access/transam/xlogreader.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Silence "missing contrecord" error. @ 2023-07-02 23:29 Thomas Munro <tmunro@postgresql.org> 0 siblings, 0 replies; 3+ messages in thread From: Thomas Munro @ 2023-07-02 23:29 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Silence "missing contrecord" error. Commit dd38ff28ad added a new error message "missing contrecord" when we fail to reassemble a record. Unfortunately that caused noisy messages to be logged by pg_waldump at end of segment, and by walsender when asked to shut down on a segment boundary. Remove the new error message, so that this condition signals end-of- WAL without a message. It's arguably a reportable condition that should not be silenced while performing crash recovery, but fixing that without introducing noise in the other cases will require more research. Back-patch to 15. Reported-by: Tomas Vondra <tomas.vondra@enterprisedb.com> Discussion: https://postgr.es/m/6a1df56e-4656-b3ce-4b7a-a9cb41df8189%40enterprisedb.com Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/f50200c0163c1dbb5aa015828e8bf32b50a2cd29 Modified Files -------------- src/backend/access/transam/xlogreader.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2023-07-02 23:29 UTC | newest] Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2023-07-02 23:28 pgsql: Silence "missing contrecord" error. Thomas Munro <tmunro@postgresql.org> 2023-07-02 23:29 pgsql: Silence "missing contrecord" error. Thomas Munro <tmunro@postgresql.org> 2023-07-02 23:29 pgsql: Silence "missing contrecord" error. Thomas Munro <tmunro@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox