pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Thomas Munro <tmunro@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Silence "missing contrecord" error.
Date: Sun, 02 Jul 2023 23:28:58 +0000
Message-ID: <E1qG6V0-001bY5-H3@gemulon.postgresql.org> (raw)

Silence "missing contrecord" error.

Commit dd38ff28ad added a new error message "missing contrecord" when
we fail to reassemble a record.  Unfortunately that caused noisy
messages to be logged by pg_waldump at end of segment, and by walsender
when asked to shut down on a segment boundary.

Remove the new error message, so that this condition signals end-of-
WAL without a message.  It's arguably a reportable condition that should
not be silenced while performing crash recovery, but fixing that without
introducing noise in the other cases will require more research.

Back-patch to 15.

Reported-by: Tomas Vondra <tomas.vondra@enterprisedb.com>
Discussion: https://postgr.es/m/6a1df56e-4656-b3ce-4b7a-a9cb41df8189%40enterprisedb.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/4637a6ac0b40fef701ab850de1be547b927c3013

Modified Files
--------------
src/backend/access/transam/xlogreader.c | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)



view thread (3+ messages)  latest in thread

Message-ID: <E1qG6V0-001bY5-H3@gemulon.postgresql.org>
Permalink:  ../E1qG6V0-001bY5-H3@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qG6V0-001bY5-H3@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tmunro@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Silence "missing contrecord" error.
  In-Reply-To: <E1qG6V0-001bY5-H3@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox