pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Improve pg_basebackup long file name test Windows robustness
10+ messages / 2 participants
[nested] [flat]

* pgsql: Improve pg_basebackup long file name test Windows robustness
@ 2023-07-03 14:08 Andrew Dunstan <andrew@dunslane.net>
  0 siblings, 0 replies; 10+ messages in thread

From: Andrew Dunstan @ 2023-07-03 14:08 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Improve pg_basebackup long file name test Windows robustness

Creation of a file with a very long name can create problems on Windows
due to its file path limits. Work around that by creating the file via a
symlink with a shorter name.

Error displayed by buildfarm animal fairywren.o

Backpatch to all live branches

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/9436535b08c13245d18c0d2567a7c00f958b833e

Modified Files
--------------
src/bin/pg_basebackup/t/010_pg_basebackup.pl | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)



^ permalink  raw  reply  [nested|flat] 10+ messages in thread

* pgsql: Improve pg_basebackup long file name test Windows robustness
@ 2023-07-03 14:08 Andrew Dunstan <andrew@dunslane.net>
  0 siblings, 0 replies; 10+ messages in thread

From: Andrew Dunstan @ 2023-07-03 14:08 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Improve pg_basebackup long file name test Windows robustness

Creation of a file with a very long name can create problems on Windows
due to its file path limits. Work around that by creating the file via a
symlink with a shorter name.

Error displayed by buildfarm animal fairywren.o

Backpatch to all live branches

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/86f23d90e560878b5b261c27263aba7d396b22ad

Modified Files
--------------
src/bin/pg_basebackup/t/010_pg_basebackup.pl | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)



^ permalink  raw  reply  [nested|flat] 10+ messages in thread

* pgsql: Improve pg_basebackup long file name test Windows robustness
@ 2023-07-03 14:08 Andrew Dunstan <andrew@dunslane.net>
  0 siblings, 0 replies; 10+ messages in thread

From: Andrew Dunstan @ 2023-07-03 14:08 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Improve pg_basebackup long file name test Windows robustness

Creation of a file with a very long name can create problems on Windows
due to its file path limits. Work around that by creating the file via a
symlink with a shorter name.

Error displayed by buildfarm animal fairywren.o

Backpatch to all live branches

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/83ed4de20fdb60457d315065fc7895dfb51108be

Modified Files
--------------
src/bin/pg_basebackup/t/010_pg_basebackup.pl | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)



^ permalink  raw  reply  [nested|flat] 10+ messages in thread

* pgsql: Improve pg_basebackup long file name test Windows robustness
@ 2023-07-03 14:08 Andrew Dunstan <andrew@dunslane.net>
  0 siblings, 0 replies; 10+ messages in thread

From: Andrew Dunstan @ 2023-07-03 14:08 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Improve pg_basebackup long file name test Windows robustness

Creation of a file with a very long name can create problems on Windows
due to its file path limits. Work around that by creating the file via a
symlink with a shorter name.

Error displayed by buildfarm animal fairywren.o

Backpatch to all live branches

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/d7a186c775834d4bf07c84a6c3de16ba94c82afa

Modified Files
--------------
src/bin/pg_basebackup/t/010_pg_basebackup.pl | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)



^ permalink  raw  reply  [nested|flat] 10+ messages in thread

* pgsql: Improve pg_basebackup long file name test Windows robustness
@ 2023-07-03 14:08 Andrew Dunstan <andrew@dunslane.net>
  2023-07-03 14:19 ` Re: pgsql: Improve pg_basebackup long file name test Windows robustness Daniel Gustafsson <daniel@yesql.se>
  0 siblings, 1 reply; 10+ messages in thread

From: Andrew Dunstan @ 2023-07-03 14:08 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Improve pg_basebackup long file name test Windows robustness

Creation of a file with a very long name can create problems on Windows
due to its file path limits. Work around that by creating the file via a
symlink with a shorter name.

Error displayed by buildfarm animal fairywren.o

Backpatch to all live branches

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/088e395c8ae06047784c41b08c54d526d00517c9

Modified Files
--------------
src/bin/pg_basebackup/t/010_pg_basebackup.pl | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)



^ permalink  raw  reply  [nested|flat] 10+ messages in thread

* Re: pgsql: Improve pg_basebackup long file name test Windows robustness
  2023-07-03 14:08 pgsql: Improve pg_basebackup long file name test Windows robustness Andrew Dunstan <andrew@dunslane.net>
@ 2023-07-03 14:19 ` Daniel Gustafsson <daniel@yesql.se>
  2023-07-03 14:51   ` Re: pgsql: Improve pg_basebackup long file name test Windows robustness Andrew Dunstan <andrew@dunslane.net>
  0 siblings, 1 reply; 10+ messages in thread

From: Daniel Gustafsson @ 2023-07-03 14:19 UTC (permalink / raw)
  To: Andrew Dunstan <andrew@dunslane.net>; +Cc: pgsql-committers@lists.postgresql.org

> On 3 Jul 2023, at 16:08, Andrew Dunstan <andrew@dunslane.net> wrote:
> 
> Improve pg_basebackup long file name test Windows robustness
> 
> Creation of a file with a very long name can create problems on Windows
> due to its file path limits. Work around that by creating the file via a
> symlink with a shorter name.

+dir_symlink "$pgdata", "$lftmp/pgdata";

dir_symlink doesn't exist in REL_12_STABLE.

--
Daniel Gustafsson






^ permalink  raw  reply  [nested|flat] 10+ messages in thread

* Re: pgsql: Improve pg_basebackup long file name test Windows robustness
  2023-07-03 14:08 pgsql: Improve pg_basebackup long file name test Windows robustness Andrew Dunstan <andrew@dunslane.net>
  2023-07-03 14:19 ` Re: pgsql: Improve pg_basebackup long file name test Windows robustness Daniel Gustafsson <daniel@yesql.se>
@ 2023-07-03 14:51   ` Andrew Dunstan <andrew@dunslane.net>
  2023-07-03 15:01     ` Re: pgsql: Improve pg_basebackup long file name test Windows robustness Andrew Dunstan <andrew@dunslane.net>
  0 siblings, 1 reply; 10+ messages in thread

From: Andrew Dunstan @ 2023-07-03 14:51 UTC (permalink / raw)
  To: Daniel Gustafsson <daniel@yesql.se>; +Cc: pgsql-committers@lists.postgresql.org


On 2023-07-03 Mo 10:19, Daniel Gustafsson wrote:
>> On 3 Jul 2023, at 16:08, Andrew Dunstan<andrew@dunslane.net>  wrote:
>>
>> Improve pg_basebackup long file name test Windows robustness
>>
>> Creation of a file with a very long name can create problems on Windows
>> due to its file path limits. Work around that by creating the file via a
>> symlink with a shorter name.
> +dir_symlink "$pgdata", "$lftmp/pgdata";
>
> dir_symlink doesn't exist in REL_12_STABLE.


Argh!. ok, thanks, will fix.


cheers


andrew


> --
> Daniel Gustafsson
>
--
Andrew Dunstan
EDB:https://www.enterprisedb.com

^ permalink  raw  reply  [nested|flat] 10+ messages in thread

* Re: pgsql: Improve pg_basebackup long file name test Windows robustness
  2023-07-03 14:08 pgsql: Improve pg_basebackup long file name test Windows robustness Andrew Dunstan <andrew@dunslane.net>
  2023-07-03 14:19 ` Re: pgsql: Improve pg_basebackup long file name test Windows robustness Daniel Gustafsson <daniel@yesql.se>
  2023-07-03 14:51   ` Re: pgsql: Improve pg_basebackup long file name test Windows robustness Andrew Dunstan <andrew@dunslane.net>
@ 2023-07-03 15:01     ` Andrew Dunstan <andrew@dunslane.net>
  0 siblings, 0 replies; 10+ messages in thread

From: Andrew Dunstan @ 2023-07-03 15:01 UTC (permalink / raw)
  To: Daniel Gustafsson <daniel@yesql.se>; +Cc: pgsql-committers@lists.postgresql.org


On 2023-07-03 Mo 10:51, Andrew Dunstan wrote:
>
>
> On 2023-07-03 Mo 10:19, Daniel Gustafsson wrote:
>>> On 3 Jul 2023, at 16:08, Andrew Dunstan<andrew@dunslane.net>  wrote:
>>>
>>> Improve pg_basebackup long file name test Windows robustness
>>>
>>> Creation of a file with a very long name can create problems on Windows
>>> due to its file path limits. Work around that by creating the file via a
>>> symlink with a shorter name.
>> +dir_symlink "$pgdata", "$lftmp/pgdata";
>>
>> dir_symlink doesn't exist in REL_12_STABLE.
>
>
> Argh!. ok, thanks, will fix.
>
>
>

Neither does rel 13 have it. I've reverted all this for versions older 
than 14. It means running TAP tests on older version on Windows could be 
fragile, but at least my animals don't run TAP tests on older versions.


cheers


andrew



--
Andrew Dunstan
EDB:https://www.enterprisedb.com

^ permalink  raw  reply  [nested|flat] 10+ messages in thread

* pgsql: Improve pg_basebackup long file name test Windows robustness
@ 2023-07-03 14:08 Andrew Dunstan <andrew@dunslane.net>
  0 siblings, 0 replies; 10+ messages in thread

From: Andrew Dunstan @ 2023-07-03 14:08 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Improve pg_basebackup long file name test Windows robustness

Creation of a file with a very long name can create problems on Windows
due to its file path limits. Work around that by creating the file via a
symlink with a shorter name.

Error displayed by buildfarm animal fairywren.o

Backpatch to all live branches

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/bb8305a654b61e2faaa38dc3d72e09bf0bd6f602

Modified Files
--------------
src/bin/pg_basebackup/t/010_pg_basebackup.pl | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)



^ permalink  raw  reply  [nested|flat] 10+ messages in thread

* pgsql: Improve pg_basebackup long file name test Windows robustness
@ 2023-07-03 14:09 Andrew Dunstan <andrew@dunslane.net>
  0 siblings, 0 replies; 10+ messages in thread

From: Andrew Dunstan @ 2023-07-03 14:09 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Improve pg_basebackup long file name test Windows robustness

Creation of a file with a very long name can create problems on Windows
due to its file path limits. Work around that by creating the file via a
symlink with a shorter name.

Error displayed by buildfarm animal fairywren.o

Backpatch to all live branches

Branch
------
REL_16_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/16152705b31d12c339e3a9ee44ed43972a6ee96c

Modified Files
--------------
src/bin/pg_basebackup/t/010_pg_basebackup.pl | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)



^ permalink  raw  reply  [nested|flat] 10+ messages in thread


end of thread, other threads:[~2023-07-03 15:01 UTC | newest]

Thread overview: 10+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2023-07-03 14:08 pgsql: Improve pg_basebackup long file name test Windows robustness Andrew Dunstan <andrew@dunslane.net>
2023-07-03 14:08 pgsql: Improve pg_basebackup long file name test Windows robustness Andrew Dunstan <andrew@dunslane.net>
2023-07-03 14:08 pgsql: Improve pg_basebackup long file name test Windows robustness Andrew Dunstan <andrew@dunslane.net>
2023-07-03 14:08 pgsql: Improve pg_basebackup long file name test Windows robustness Andrew Dunstan <andrew@dunslane.net>
2023-07-03 14:08 pgsql: Improve pg_basebackup long file name test Windows robustness Andrew Dunstan <andrew@dunslane.net>
2023-07-03 14:19 ` Daniel Gustafsson <daniel@yesql.se>
2023-07-03 14:51   ` Andrew Dunstan <andrew@dunslane.net>
2023-07-03 15:01     ` Andrew Dunstan <andrew@dunslane.net>
2023-07-03 14:08 pgsql: Improve pg_basebackup long file name test Windows robustness Andrew Dunstan <andrew@dunslane.net>
2023-07-03 14:09 pgsql: Improve pg_basebackup long file name test Windows robustness Andrew Dunstan <andrew@dunslane.net>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox