pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Remove expensive test of postgres_fdw batch inserts
4+ messages / 1 participants
[nested] [flat]

* pgsql: Remove expensive test of postgres_fdw batch inserts
@ 2023-07-03 16:46 Tomas Vondra <tomas.vondra@postgresql.org>
  0 siblings, 0 replies; 4+ messages in thread

From: Tomas Vondra @ 2023-07-03 16:46 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Remove expensive test of postgres_fdw batch inserts

The test inserted 70k rows into a foreign table, in order to verify
correct behavior with more than 65535 parameters, and was added in
response to a bug report.

However, this is rather expensive, especially when running the tests
under valgrind, CLOBBER_CACHE_ALWAYS etc. It doesn't seem worth it to
keep running the test, so remove it from all branches (14+).

Backpatch-through: 14
Discussion: https://postgr.es/m/2131017.1623451468@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/087a933b21cc114653008682356e50e0ecbbd812

Modified Files
--------------
contrib/postgres_fdw/expected/postgres_fdw.out | 11 -----------
contrib/postgres_fdw/sql/postgres_fdw.sql      |  7 -------
2 files changed, 18 deletions(-)



^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* pgsql: Remove expensive test of postgres_fdw batch inserts
@ 2023-07-03 16:46 Tomas Vondra <tomas.vondra@postgresql.org>
  0 siblings, 0 replies; 4+ messages in thread

From: Tomas Vondra @ 2023-07-03 16:46 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Remove expensive test of postgres_fdw batch inserts

The test inserted 70k rows into a foreign table, in order to verify
correct behavior with more than 65535 parameters, and was added in
response to a bug report.

However, this is rather expensive, especially when running the tests
under valgrind, CLOBBER_CACHE_ALWAYS etc. It doesn't seem worth it to
keep running the test, so remove it from all branches (14+).

Backpatch-through: 14
Discussion: https://postgr.es/m/2131017.1623451468@sss.pgh.pa.us

Branch
------
REL_16_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/6b488d5dc2fe4dc12e1ef15c0ea4c1a4e7170ae0

Modified Files
--------------
contrib/postgres_fdw/expected/postgres_fdw.out | 11 -----------
contrib/postgres_fdw/sql/postgres_fdw.sql      |  7 -------
2 files changed, 18 deletions(-)



^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* pgsql: Remove expensive test of postgres_fdw batch inserts
@ 2023-07-03 16:46 Tomas Vondra <tomas.vondra@postgresql.org>
  0 siblings, 0 replies; 4+ messages in thread

From: Tomas Vondra @ 2023-07-03 16:46 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Remove expensive test of postgres_fdw batch inserts

The test inserted 70k rows into a foreign table, in order to verify
correct behavior with more than 65535 parameters, and was added in
response to a bug report.

However, this is rather expensive, especially when running the tests
under valgrind, CLOBBER_CACHE_ALWAYS etc. It doesn't seem worth it to
keep running the test, so remove it from all branches (14+).

Backpatch-through: 14
Discussion: https://postgr.es/m/2131017.1623451468@sss.pgh.pa.us

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/23ce74811a1d10c873cdafe5b264d630e5ab74d4

Modified Files
--------------
contrib/postgres_fdw/expected/postgres_fdw.out | 11 -----------
contrib/postgres_fdw/sql/postgres_fdw.sql      |  7 -------
2 files changed, 18 deletions(-)



^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* pgsql: Remove expensive test of postgres_fdw batch inserts
@ 2023-07-03 16:46 Tomas Vondra <tomas.vondra@postgresql.org>
  0 siblings, 0 replies; 4+ messages in thread

From: Tomas Vondra @ 2023-07-03 16:46 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Remove expensive test of postgres_fdw batch inserts

The test inserted 70k rows into a foreign table, in order to verify
correct behavior with more than 65535 parameters, and was added in
response to a bug report.

However, this is rather expensive, especially when running the tests
under valgrind, CLOBBER_CACHE_ALWAYS etc. It doesn't seem worth it to
keep running the test, so remove it from all branches (14+).

Backpatch-through: 14
Discussion: https://postgr.es/m/2131017.1623451468@sss.pgh.pa.us

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/5396b188c92213216248fa8f311c0f031a137e2a

Modified Files
--------------
contrib/postgres_fdw/expected/postgres_fdw.out | 11 -----------
contrib/postgres_fdw/sql/postgres_fdw.sql      |  7 -------
2 files changed, 18 deletions(-)



^ permalink  raw  reply  [nested|flat] 4+ messages in thread


end of thread, other threads:[~2023-07-03 16:46 UTC | newest]

Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2023-07-03 16:46 pgsql: Remove expensive test of postgres_fdw batch inserts Tomas Vondra <tomas.vondra@postgresql.org>
2023-07-03 16:46 pgsql: Remove expensive test of postgres_fdw batch inserts Tomas Vondra <tomas.vondra@postgresql.org>
2023-07-03 16:46 pgsql: Remove expensive test of postgres_fdw batch inserts Tomas Vondra <tomas.vondra@postgresql.org>
2023-07-03 16:46 pgsql: Remove expensive test of postgres_fdw batch inserts Tomas Vondra <tomas.vondra@postgresql.org>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox