pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tomas Vondra <tomas.vondra@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove expensive test of postgres_fdw batch inserts
Date: Mon, 03 Jul 2023 16:46:42 +0000
Message-ID: <E1qGMhG-001jMY-Tg@gemulon.postgresql.org> (raw)

Remove expensive test of postgres_fdw batch inserts

The test inserted 70k rows into a foreign table, in order to verify
correct behavior with more than 65535 parameters, and was added in
response to a bug report.

However, this is rather expensive, especially when running the tests
under valgrind, CLOBBER_CACHE_ALWAYS etc. It doesn't seem worth it to
keep running the test, so remove it from all branches (14+).

Backpatch-through: 14
Discussion: https://postgr.es/m/2131017.1623451468@sss.pgh.pa.us

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/5396b188c92213216248fa8f311c0f031a137e2a

Modified Files
--------------
contrib/postgres_fdw/expected/postgres_fdw.out | 11 -----------
contrib/postgres_fdw/sql/postgres_fdw.sql      |  7 -------
2 files changed, 18 deletions(-)



view thread (4+ messages)

Message-ID: <E1qGMhG-001jMY-Tg@gemulon.postgresql.org>
Permalink:  ../E1qGMhG-001jMY-Tg@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qGMhG-001jMY-Tg@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tomas.vondra@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Remove expensive test of postgres_fdw batch inserts
  In-Reply-To: <E1qGMhG-001jMY-Tg@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox