From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Handle \v as a whitespace character in parsers
Date: Wed, 05 Jul 2023 23:18:49 +0000
Message-ID: <E1qHBlp-0026M7-D6@gemulon.postgresql.org> (raw)
Handle \v as a whitespace character in parsers
This commit comes as a continuation of the discussion that has led to
d522b05, as \v was handled inconsistently when parsing array values or
anything going through the parsers, and changing a parser behavior in
stable branches is a scary thing to do. The parsing of array values now
uses the more central scanner_isspace() and array_isspace() is removed.
As pointing out by Peter Eisentraut, fix a confusing reference to
horizontal space in the parsers with the term "horiz_space". \f was
included in this set since 3cfdd8f from 2000, but it is not horizontal.
"horiz_space" is renamed to "non_newline_space", to refer to all
whitespace characters except newlines.
The changes impact the parsers for the backend, psql, seg, cube, ecpg
and replication commands. Note that JSON should not escape \v, as per
RFC 7159, so these are not touched.
Reviewed-by: Peter Eisentraut, Tom Lane
Discussion: https://postgr.es/m/ZJKcjNwWHHvw9ksQ@paquier.xyz
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/ae6d06f09684d8f8a7084514c9b35a274babca61
Modified Files
--------------
contrib/cube/cubescan.l | 2 +-
contrib/hstore/expected/hstore_utf8.out | 31 +++++++++++++++++++++++++++++
contrib/hstore/sql/hstore_utf8.sql | 7 +++++++
contrib/seg/segscan.l | 2 +-
src/backend/parser/parse_type.c | 2 +-
src/backend/parser/scan.l | 16 ++++++++-------
src/backend/parser/scansup.c | 1 +
src/backend/replication/repl_scanner.l | 2 +-
src/backend/utils/adt/arrayfuncs.c | 35 +++++++--------------------------
src/bin/psql/psqlscanslash.l | 2 +-
src/fe_utils/psqlscan.l | 14 ++++++-------
src/fe_utils/string_utils.c | 2 +-
src/interfaces/ecpg/preproc/pgc.l | 17 ++++++++--------
13 files changed, 77 insertions(+), 56 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Handle \v as a whitespace character in parsers
In-Reply-To: <E1qHBlp-0026M7-D6@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox