pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Revert the commits related to allowing page lock to conflict amo 5+ messages / 1 participants [nested] [flat]
* pgsql: Revert the commits related to allowing page lock to conflict amo @ 2023-07-06 03:34 Amit Kapila <akapila@postgresql.org> 0 siblings, 0 replies; 5+ messages in thread From: Amit Kapila @ 2023-07-06 03:34 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Revert the commits related to allowing page lock to conflict among parallel group members. This commit reverts the work done by commits 3ba59ccc89 and 72e78d831a. Those commits were incorrect in asserting that we never acquire any other heavy-weight lock after acquring page lock other than relation extension lock. We can acquire a lock on catalogs while doing catalog look up after acquring page lock. This won't impact any existing feature but we need to think some other way to achieve this before parallelizing other write operations or even improving the parallelism in vacuum (like allowing multiple workers for an index). Reported-by: Jaime Casanova Author: Amit Kapila Backpatch-through: 13 Discussion: https://postgr.es/m/CAJKUy5jffnRKNvRHKQ0LynRb0RJC-o4P8Ku3x9vGAVLwDBWumQ@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/cc32ec24fdf3b9808617439d41b0ba7f3eb16b04 Modified Files -------------- src/backend/optimizer/plan/planner.c | 12 +++++++----- src/backend/storage/lmgr/README | 34 +++++++++++++--------------------- src/backend/storage/lmgr/deadlock.c | 9 ++++----- src/backend/storage/lmgr/lock.c | 32 ++++---------------------------- src/backend/storage/lmgr/proc.c | 12 ++++++------ 5 files changed, 34 insertions(+), 65 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Revert the commits related to allowing page lock to conflict amo @ 2023-07-06 03:34 Amit Kapila <akapila@postgresql.org> 0 siblings, 0 replies; 5+ messages in thread From: Amit Kapila @ 2023-07-06 03:34 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Revert the commits related to allowing page lock to conflict among parallel group members. This commit reverts the work done by commits 3ba59ccc89 and 72e78d831a. Those commits were incorrect in asserting that we never acquire any other heavy-weight lock after acquring page lock other than relation extension lock. We can acquire a lock on catalogs while doing catalog look up after acquring page lock. This won't impact any existing feature but we need to think some other way to achieve this before parallelizing other write operations or even improving the parallelism in vacuum (like allowing multiple workers for an index). Reported-by: Jaime Casanova Author: Amit Kapila Backpatch-through: 13 Discussion: https://postgr.es/m/CAJKUy5jffnRKNvRHKQ0LynRb0RJC-o4P8Ku3x9vGAVLwDBWumQ@mail.gmail.com Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/3c1adbbf86c2cfa44ebed64bd01ed589ad0b832b Modified Files -------------- src/backend/optimizer/plan/planner.c | 12 +++++++----- src/backend/storage/lmgr/README | 34 +++++++++++++--------------------- src/backend/storage/lmgr/deadlock.c | 9 ++++----- src/backend/storage/lmgr/lock.c | 32 ++++---------------------------- src/backend/storage/lmgr/proc.c | 12 ++++++------ 5 files changed, 34 insertions(+), 65 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Revert the commits related to allowing page lock to conflict amo @ 2023-07-06 03:34 Amit Kapila <akapila@postgresql.org> 0 siblings, 0 replies; 5+ messages in thread From: Amit Kapila @ 2023-07-06 03:34 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Revert the commits related to allowing page lock to conflict among parallel group members. This commit reverts the work done by commits 3ba59ccc89 and 72e78d831a. Those commits were incorrect in asserting that we never acquire any other heavy-weight lock after acquring page lock other than relation extension lock. We can acquire a lock on catalogs while doing catalog look up after acquring page lock. This won't impact any existing feature but we need to think some other way to achieve this before parallelizing other write operations or even improving the parallelism in vacuum (like allowing multiple workers for an index). Reported-by: Jaime Casanova Author: Amit Kapila Backpatch-through: 13 Discussion: https://postgr.es/m/CAJKUy5jffnRKNvRHKQ0LynRb0RJC-o4P8Ku3x9vGAVLwDBWumQ@mail.gmail.com Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/907d3dd53159fb50402ec292ad60b2452c281310 Modified Files -------------- src/backend/optimizer/plan/planner.c | 12 +++++++----- src/backend/storage/lmgr/README | 34 +++++++++++++--------------------- src/backend/storage/lmgr/deadlock.c | 9 ++++----- src/backend/storage/lmgr/lock.c | 32 ++++---------------------------- src/backend/storage/lmgr/proc.c | 12 ++++++------ 5 files changed, 34 insertions(+), 65 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Revert the commits related to allowing page lock to conflict amo @ 2023-07-06 03:34 Amit Kapila <akapila@postgresql.org> 0 siblings, 0 replies; 5+ messages in thread From: Amit Kapila @ 2023-07-06 03:34 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Revert the commits related to allowing page lock to conflict among parallel group members. This commit reverts the work done by commits 3ba59ccc89 and 72e78d831a. Those commits were incorrect in asserting that we never acquire any other heavy-weight lock after acquring page lock other than relation extension lock. We can acquire a lock on catalogs while doing catalog look up after acquring page lock. This won't impact any existing feature but we need to think some other way to achieve this before parallelizing other write operations or even improving the parallelism in vacuum (like allowing multiple workers for an index). Reported-by: Jaime Casanova Author: Amit Kapila Backpatch-through: 13 Discussion: https://postgr.es/m/CAJKUy5jffnRKNvRHKQ0LynRb0RJC-o4P8Ku3x9vGAVLwDBWumQ@mail.gmail.com Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/cf3e29851278e18b7b4997cd0bd90edb372c69da Modified Files -------------- src/backend/optimizer/plan/planner.c | 12 +++++++----- src/backend/storage/lmgr/README | 34 +++++++++++++--------------------- src/backend/storage/lmgr/deadlock.c | 9 ++++----- src/backend/storage/lmgr/lock.c | 32 ++++---------------------------- src/backend/storage/lmgr/proc.c | 12 ++++++------ 5 files changed, 34 insertions(+), 65 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Revert the commits related to allowing page lock to conflict amo @ 2023-07-06 03:34 Amit Kapila <akapila@postgresql.org> 0 siblings, 0 replies; 5+ messages in thread From: Amit Kapila @ 2023-07-06 03:34 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Revert the commits related to allowing page lock to conflict among parallel group members. This commit reverts the work done by commits 3ba59ccc89 and 72e78d831a. Those commits were incorrect in asserting that we never acquire any other heavy-weight lock after acquring page lock other than relation extension lock. We can acquire a lock on catalogs while doing catalog look up after acquring page lock. This won't impact any existing feature but we need to think some other way to achieve this before parallelizing other write operations or even improving the parallelism in vacuum (like allowing multiple workers for an index). Reported-by: Jaime Casanova Author: Amit Kapila Backpatch-through: 13 Discussion: https://postgr.es/m/CAJKUy5jffnRKNvRHKQ0LynRb0RJC-o4P8Ku3x9vGAVLwDBWumQ@mail.gmail.com Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/34f6c606356887d6f5090c92fe7247cbf7946ef0 Modified Files -------------- src/backend/optimizer/plan/planner.c | 12 +++++++----- src/backend/storage/lmgr/README | 34 +++++++++++++--------------------- src/backend/storage/lmgr/deadlock.c | 9 ++++----- src/backend/storage/lmgr/lock.c | 32 ++++---------------------------- src/backend/storage/lmgr/proc.c | 12 ++++++------ 5 files changed, 34 insertions(+), 65 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
end of thread, other threads:[~2023-07-06 03:34 UTC | newest] Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2023-07-06 03:34 pgsql: Revert the commits related to allowing page lock to conflict amo Amit Kapila <akapila@postgresql.org> 2023-07-06 03:34 pgsql: Revert the commits related to allowing page lock to conflict amo Amit Kapila <akapila@postgresql.org> 2023-07-06 03:34 pgsql: Revert the commits related to allowing page lock to conflict amo Amit Kapila <akapila@postgresql.org> 2023-07-06 03:34 pgsql: Revert the commits related to allowing page lock to conflict amo Amit Kapila <akapila@postgresql.org> 2023-07-06 03:34 pgsql: Revert the commits related to allowing page lock to conflict amo Amit Kapila <akapila@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox