pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Amit Kapila <akapila@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Revert the commits related to allowing page lock to conflict amo
Date: Thu, 06 Jul 2023 03:34:51 +0000
Message-ID: <E1qHFlb-0028Bk-81@gemulon.postgresql.org> (raw)

Revert the commits related to allowing page lock to conflict among parallel group members.

This commit reverts the work done by commits 3ba59ccc89 and 72e78d831a.
Those commits were incorrect in asserting that we never acquire any other
heavy-weight lock after acquring page lock other than relation extension
lock. We can acquire a lock on catalogs while doing catalog look up after
acquring page lock.

This won't impact any existing feature but we need to think some other way
to achieve this before parallelizing other write operations or even
improving the parallelism in vacuum (like allowing multiple workers
for an index).

Reported-by: Jaime Casanova
Author: Amit Kapila
Backpatch-through: 13
Discussion: https://postgr.es/m/CAJKUy5jffnRKNvRHKQ0LynRb0RJC-o4P8Ku3x9vGAVLwDBWumQ@mail.gmail.com

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/cf3e29851278e18b7b4997cd0bd90edb372c69da

Modified Files
--------------
src/backend/optimizer/plan/planner.c | 12 +++++++-----
src/backend/storage/lmgr/README      | 34 +++++++++++++---------------------
src/backend/storage/lmgr/deadlock.c  |  9 ++++-----
src/backend/storage/lmgr/lock.c      | 32 ++++----------------------------
src/backend/storage/lmgr/proc.c      | 12 ++++++------
5 files changed, 34 insertions(+), 65 deletions(-)



view thread (5+ messages)  latest in thread

Message-ID: <E1qHFlb-0028Bk-81@gemulon.postgresql.org>
Permalink:  ../E1qHFlb-0028Bk-81@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qHFlb-0028Bk-81@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: akapila@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Revert the commits related to allowing page lock to conflict amo
  In-Reply-To: <E1qHFlb-0028Bk-81@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox