pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Heikki Linnakangas <heikki.linnakangas@iki.fi>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: WAL-log the creation of the init fork of unlogged indexes.
Date: Thu, 06 Jul 2023 14:30:12 +0000
Message-ID: <E1qHPzp-002Ctj-2x@gemulon.postgresql.org> (raw)

WAL-log the creation of the init fork of unlogged indexes.

We create a file, so we better WAL-log it. In practice, all the
built-in index AMs and all extensions that I'm aware of write a
metapage to the init fork, which is WAL-logged, and replay of the
metapage implicitly creates the fork too. But if ambuildempty() didn't
write any page, we would miss it.

This can be seen with dummy_index_am. Set up replication, create a
'dummy_index_am' index on an unlogged table, and look at the files
created in the replica: the init fork is not created on the
replica. Dummy_index_am doesn't do anything with the relation files,
however, so it doesn't lead to any user-visible errors.

Backpatch to all supported versions.

Reviewed-by: Robert Haas
Discussion: https://www.postgresql.org/message-id/6e5bbc08-cdfc-b2b3-9e23-1a914b9850a9%40iki.fi

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/988719b88d1e558e9a45d53bb36ba4a748f42b24

Modified Files
--------------
src/backend/catalog/index.c | 2 ++
1 file changed, 2 insertions(+)



view thread (7+ messages)  latest in thread

Message-ID: <E1qHPzp-002Ctj-2x@gemulon.postgresql.org>
Permalink:  ../E1qHPzp-002Ctj-2x@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qHPzp-002Ctj-2x@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: heikki.linnakangas@iki.fi, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: WAL-log the creation of the init fork of unlogged indexes.
  In-Reply-To: <E1qHPzp-002Ctj-2x@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox