pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andrew Dunstan <andrew@dunslane.net>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Skip pg_baseback long filename test if path too long on Windows
Date: Thu, 06 Jul 2023 16:37:55 +0000
Message-ID: <E1qHRzP-002Dwj-LX@gemulon.postgresql.org> (raw)

Skip pg_baseback long filename test if path too long on Windows

On Windows, it's sometimes difficult to create a file with a path longer
than 255 chars, and if it can be created it might not be seen by the
archiver. This can be triggered by the test for tar backups with
filenames greater than 100 bytes. So we skip that test if the path would
exceed 255.

Backpatch to all live branches.

Reviewed by Daniel Gustafsson

Discussion: https://postgr.es/m/666ac55b-3400-fb2c-2cea-0281bf36a53c@dunslane.net

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/9ebe6fdc5c684c21a44aeaf98837c54d7415ca2a

Modified Files
--------------
src/bin/pg_basebackup/t/010_pg_basebackup.pl | 24 +++++++++++++++---------
1 file changed, 15 insertions(+), 9 deletions(-)



view thread (7+ messages)  latest in thread

Message-ID: <E1qHRzP-002Dwj-LX@gemulon.postgresql.org>
Permalink:  ../E1qHRzP-002Dwj-LX@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qHRzP-002Dwj-LX@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: andrew@dunslane.net, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Skip pg_baseback long filename test if path too long on Windows
  In-Reply-To: <E1qHRzP-002Dwj-LX@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox