pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Amit Kapila <akapila@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Add BEGIN/COMMIT for transactional messages during decoding.
Date: Tue, 11 Jul 2023 03:03:15 +0000
Message-ID: <E1qJ3el-002v1x-BL@gemulon.postgresql.org> (raw)

Add BEGIN/COMMIT for transactional messages during decoding.

In test_decoding module, when skip_empty_xacts option was specified, add
BEGIN/COMMIT for transactional messages. This makes the handling of
transactional messages consistent irrespective of whether skip_empty_xacts
option was specified.

We decided not to backpatch this change because skip_empty_xacts is
primarily used to have consistent test results across different runs and
this change won't help with that.

Author: Vignesh C
Reviewed-by: Ashutosh Bapat, Hou Zhijie
Discussion: https://postgr.es/m/CAExHW5ujRhbOz6_aTq_jQA8NjeFqq9d_8G9viShWvXx8gdSXiQ@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/26dd0284b98f6bf730dc1f7f7e1f917525d71eda

Modified Files
--------------
contrib/test_decoding/expected/messages.out | 10 ++++++++--
contrib/test_decoding/sql/messages.sql      |  2 +-
contrib/test_decoding/test_decoding.c       | 12 ++++++++++++
3 files changed, 21 insertions(+), 3 deletions(-)



Message-ID: <E1qJ3el-002v1x-BL@gemulon.postgresql.org>
Permalink:  ../E1qJ3el-002v1x-BL@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qJ3el-002v1x-BL@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: akapila@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Add BEGIN/COMMIT for transactional messages during decoding.
  In-Reply-To: <E1qJ3el-002v1x-BL@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox