pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove ancient special case code for adding oid columns
Date: Wed, 12 Jul 2023 14:21:34 +0000
Message-ID: <E1qJaik-0000pp-1R@gemulon.postgresql.org> (raw)

Remove ancient special case code for adding oid columns

The special handling of negative attribute numbers in
ATExecAddColumn() was introduced to support SET WITH OIDS (commit
6d1e361852).  But that feature doesn't exist anymore, so we can revert
to the previous, simpler version.  In passing, also remove an obsolete
comment about OID support.

Reviewed-by: Alvaro Herrera <alvherre@alvh.no-ip.org>
Discussion: https://www.postgresql.org/message-id/flat/52a125e4-ff9a-95f5-9f61-b87cf447e4da@eisentraut.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/5eaa0e92ee2f94994c55c02d01b3feabc6c35f54

Modified Files
--------------
src/backend/commands/tablecmds.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)



view thread (2+ messages)

Message-ID: <E1qJaik-0000pp-1R@gemulon.postgresql.org>
Permalink:  ../E1qJaik-0000pp-1R@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qJaik-0000pp-1R@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Remove ancient special case code for adding oid columns
  In-Reply-To: <E1qJaik-0000pp-1R@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox