pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Amit Langote <amitlan@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Don't include CaseTestExpr in JsonValueExpr.formatted_expr
Date: Thu, 13 Jul 2023 03:33:07 +0000
Message-ID: <E1qJn4l-00072K-8q@gemulon.postgresql.org> (raw)

Don't include CaseTestExpr in JsonValueExpr.formatted_expr

A CaseTestExpr is currently being put into
JsonValueExpr.formatted_expr as placeholder for the result of
evaluating JsonValueExpr.raw_expr, which in turn is evaluated
separately.  Though, there's no need for this indirection if
raw_expr itself can be embedded into formatted_expr and evaluated
as part of evaluating the latter, especially as there is no
special reason to evaluate it separately.  So this commit makes it
so.  As a result, JsonValueExpr.raw_expr no longer needs to be
evaluated in ExecInterpExpr(), eval_const_exprs_mutator() etc. and
is now only used for displaying the original "unformatted"
expression in ruleutils.c.

While at it, this also removes the function makeCaseTestExpr(),
because the code in makeJsonConstructorExpr() looks more readable
without it IMO and isn't used by anyone else either.

Finally, a note is added in the comment above CaseTestExpr's
definition that JsonConstructorExpr is also using it.

Reviewed-by: Álvaro Herrera <alvherre@alvh.no-ip.org>
Discussion: https://postgr.es/m/CA+HiwqE4XTdfb1nW=Ojoy_tQSRhYt-q_kb6i5d4xcKyrLC1Nbg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b6e1157e7d339c4e20d68448125a4cef42b1ac9d

Modified Files
--------------
src/backend/executor/execExpr.c      | 17 ++------------
src/backend/nodes/makefuncs.c        |  4 ++++
src/backend/optimizer/util/clauses.c | 23 +++++--------------
src/backend/parser/parse_expr.c      | 43 ++++++++++++++++++------------------
src/include/nodes/primnodes.h        |  7 +++++-
5 files changed, 39 insertions(+), 55 deletions(-)



view thread (4+ messages)  latest in thread

Message-ID: <E1qJn4l-00072K-8q@gemulon.postgresql.org>
Permalink:  ../E1qJn4l-00072K-8q@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qJn4l-00072K-8q@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: amitlan@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Don't include CaseTestExpr in JsonValueExpr.formatted_expr
  In-Reply-To: <E1qJn4l-00072K-8q@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox