pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Thomas Munro <tmunro@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove wal_sync_method=fsync_writethrough on Windows.
Date: Fri, 14 Jul 2023 00:30:37 +0000
Message-ID: <E1qK6hh-000FKc-6o@gemulon.postgresql.org> (raw)

Remove wal_sync_method=fsync_writethrough on Windows.

The "fsync" level already flushes drive write caches on Windows (as does
"fdatasync"), so it only confuses matters to have an apparently higher
level that isn't actually different at all.

That leaves "fsync_writethrough" only for macOS, where it actually does
something different.

Reviewed-by: Magnus Hagander <magnus@hagander.net>
Discussion: https://postgr.es/m/CA%2BhUKGJ2CG2SouPv2mca2WCTOJxYumvBARRcKPraFMB6GSEMcA%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d0c28601efaa8b04f11a19506f3371bba8438acc

Modified Files
--------------
doc/src/sgml/wal.sgml                 | 5 ++---
src/backend/storage/file/fd.c         | 6 ++----
src/bin/pg_test_fsync/pg_test_fsync.c | 4 +---
src/include/port/win32_port.h         | 8 --------
4 files changed, 5 insertions(+), 18 deletions(-)



Message-ID: <E1qK6hh-000FKc-6o@gemulon.postgresql.org>
Permalink:  ../E1qK6hh-000FKc-6o@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qK6hh-000FKc-6o@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tmunro@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Remove wal_sync_method=fsync_writethrough on Windows.
  In-Reply-To: <E1qK6hh-000FKc-6o@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox