pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Include <limits.h> in fe-auth.c, to get CHAR_BIT reliably.
Date: Mon, 17 Jul 2023 20:55:02 +0000
Message-ID: <E1qLVFG-000sdh-CH@gemulon.postgresql.org> (raw)

Include <limits.h> in fe-auth.c, to get CHAR_BIT reliably.

fe-auth.c references CHAR_BIT since commit 3a465cc67, but it
did not #include <limits.h>, which per POSIX is where that
symbol is defined.  This escaped notice so far because
(a) on most platforms, <sys/param.h> pulls in <limits.h>,
(b) even if yours doesn't, OpenSSL pulls it in, so compiling
with --with-openssl masks the omission.

Per bug #18026 from Marcel Hofstetter.  Back-patch to v16.

Discussion: https://postgr.es/m/18026-d5bb69f79cd16203@postgresql.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/8fab4b34801331f1c59352cb0a248be436b60aef

Modified Files
--------------
src/interfaces/libpq/fe-auth.c | 1 +
1 file changed, 1 insertion(+)



view thread (2+ messages)  latest in thread

Message-ID: <E1qLVFG-000sdh-CH@gemulon.postgresql.org>
Permalink:  ../E1qLVFG-000sdh-CH@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qLVFG-000sdh-CH@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Include <limits.h> in fe-auth.c, to get CHAR_BIT reliably.
  In-Reply-To: <E1qLVFG-000sdh-CH@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox