pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Include <limits.h> in fe-auth.c, to get CHAR_BIT reliably. 2+ messages / 1 participants [nested] [flat]
* pgsql: Include <limits.h> in fe-auth.c, to get CHAR_BIT reliably. @ 2023-07-17 20:55 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 2+ messages in thread From: Tom Lane @ 2023-07-17 20:55 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Include <limits.h> in fe-auth.c, to get CHAR_BIT reliably. fe-auth.c references CHAR_BIT since commit 3a465cc67, but it did not #include <limits.h>, which per POSIX is where that symbol is defined. This escaped notice so far because (a) on most platforms, <sys/param.h> pulls in <limits.h>, (b) even if yours doesn't, OpenSSL pulls it in, so compiling with --with-openssl masks the omission. Per bug #18026 from Marcel Hofstetter. Back-patch to v16. Discussion: https://postgr.es/m/18026-d5bb69f79cd16203@postgresql.org Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/8fab4b34801331f1c59352cb0a248be436b60aef Modified Files -------------- src/interfaces/libpq/fe-auth.c | 1 + 1 file changed, 1 insertion(+) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Include <limits.h> in fe-auth.c, to get CHAR_BIT reliably. @ 2023-07-17 20:55 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 2+ messages in thread From: Tom Lane @ 2023-07-17 20:55 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Include <limits.h> in fe-auth.c, to get CHAR_BIT reliably. fe-auth.c references CHAR_BIT since commit 3a465cc67, but it did not #include <limits.h>, which per POSIX is where that symbol is defined. This escaped notice so far because (a) on most platforms, <sys/param.h> pulls in <limits.h>, (b) even if yours doesn't, OpenSSL pulls it in, so compiling with --with-openssl masks the omission. Per bug #18026 from Marcel Hofstetter. Back-patch to v16. Discussion: https://postgr.es/m/18026-d5bb69f79cd16203@postgresql.org Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/efe8d8226929137f8c96f45e0904868b53ba56bc Modified Files -------------- src/interfaces/libpq/fe-auth.c | 1 + 1 file changed, 1 insertion(+) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2023-07-17 20:55 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2023-07-17 20:55 pgsql: Include <limits.h> in fe-auth.c, to get CHAR_BIT reliably. Tom Lane <tgl@sss.pgh.pa.us> 2023-07-17 20:55 pgsql: Include <limits.h> in fe-auth.c, to get CHAR_BIT reliably. Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox