pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Add missing ObjectIdGetDatum() in syscache lookup calls for Oids
Date: Thu, 20 Jul 2023 06:19:05 +0000
Message-ID: <E1qMN0C-000P1g-70@gemulon.postgresql.org> (raw)

Add missing ObjectIdGetDatum() in syscache lookup calls for Oids

Based on how postgres.h foes the Oid <-> Datum conversion, there is no
existing bugs but let's be consistent.  17 spots have been noticed as
incorrectly passing down Oids rather than Datums.  Aleksander got one,
Zhang two and I the rest.

Author: Michael Paquier, Aleksander Alekseev, Zhang Mingli
Discussion: https://postgr.es/m/ZLUhqsqQN1MOaxdw@paquier.xyz

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/2a990abd79acea4717cc8f982a28f35b6b347ddb

Modified Files
--------------
src/backend/catalog/index.c           | 2 +-
src/backend/commands/alter.c          | 3 ++-
src/backend/commands/sequence.c       | 4 ++--
src/backend/commands/tablecmds.c      | 9 +++++----
src/backend/commands/user.c           | 2 +-
src/backend/partitioning/partbounds.c | 2 +-
src/backend/partitioning/partdesc.c   | 2 +-
src/backend/utils/adt/acl.c           | 4 ++--
src/backend/utils/adt/ruleutils.c     | 2 +-
src/backend/utils/cache/lsyscache.c   | 6 ++++--
src/backend/utils/cache/partcache.c   | 3 ++-
11 files changed, 22 insertions(+), 17 deletions(-)



Message-ID: <E1qMN0C-000P1g-70@gemulon.postgresql.org>
Permalink:  ../E1qMN0C-000P1g-70@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qMN0C-000P1g-70@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Add missing ObjectIdGetDatum() in syscache lookup calls for Oids
  In-Reply-To: <E1qMN0C-000P1g-70@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox