pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Pass constructName to transformJsonValueExpr()
4+ messages / 3 participants
[nested] [flat]

Commits from this thread:
  2023-07-13 40b3af72a7  Add missing const qualifier
* pgsql: Pass constructName to transformJsonValueExpr()
@ 2023-07-13 03:33 Amit Langote <amitlan@postgresql.org>
  2023-07-13 04:08 ` Re: pgsql: Pass constructName to transformJsonValueExpr() Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 1 reply; 4+ messages in thread

From: Amit Langote @ 2023-07-13 03:33 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Pass constructName to transformJsonValueExpr()

This allows it to pass to coerce_to_specific_type() the actual name
corresponding to the specific JSON_* function expression being
transformed, instead of the currently hardcoded string.

Reviewed-by: Álvaro Herrera <alvherre@alvh.no-ip.org>
Discussion: https://postgr.es/m/CA+HiwqE4XTdfb1nW=Ojoy_tQSRhYt-q_kb6i5d4xcKyrLC1Nbg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/785480c9533d9a905410c1a52f857a431daec37c

Modified Files
--------------
src/backend/parser/parse_expr.c | 24 +++++++++++++-----------
1 file changed, 13 insertions(+), 11 deletions(-)



^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* Re: pgsql: Pass constructName to transformJsonValueExpr()
  2023-07-13 03:33 pgsql: Pass constructName to transformJsonValueExpr() Amit Langote <amitlan@postgresql.org>
@ 2023-07-13 04:08 ` Tom Lane <tgl@sss.pgh.pa.us>
  2023-07-13 13:41   ` Re: pgsql: Pass constructName to transformJsonValueExpr() Amit Langote <amitlangote09@gmail.com>
  0 siblings, 1 reply; 4+ messages in thread

From: Tom Lane @ 2023-07-13 04:08 UTC (permalink / raw)
  To: Amit Langote <amitlan@postgresql.org>; +Cc: pgsql-committers@lists.postgresql.org

Amit Langote <amitlan@postgresql.org> writes:
> Pass constructName to transformJsonValueExpr()

Surely "char *constructName" should be "const char *constructName"?

			regards, tom lane





^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* Re: pgsql: Pass constructName to transformJsonValueExpr()
  2023-07-13 03:33 pgsql: Pass constructName to transformJsonValueExpr() Amit Langote <amitlan@postgresql.org>
  2023-07-13 04:08 ` Re: pgsql: Pass constructName to transformJsonValueExpr() Tom Lane <tgl@sss.pgh.pa.us>
@ 2023-07-13 13:41   ` Amit Langote <amitlangote09@gmail.com>
  0 siblings, 0 replies; 4+ messages in thread

From: Amit Langote @ 2023-07-13 13:41 UTC (permalink / raw)
  To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Amit Langote <amitlan@postgresql.org>; pgsql-committers@lists.postgresql.org

On Thu, Jul 13, 2023 at 1:08 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Amit Langote <amitlan@postgresql.org> writes:
> > Pass constructName to transformJsonValueExpr()
>
> Surely "char *constructName" should be "const char *constructName"?

Right you are.  Fixed.

-- 
Thanks, Amit Langote
EDB: http://www.enterprisedb.com





^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* pgsql: Pass constructName to transformJsonValueExpr()
@ 2023-07-20 08:15 Amit Langote <amitlan@postgresql.org>
  0 siblings, 0 replies; 4+ messages in thread

From: Amit Langote @ 2023-07-20 08:15 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Pass constructName to transformJsonValueExpr()

This allows it to pass to coerce_to_specific_type() the actual name
corresponding to the specific JSON_* function expression being
transformed, instead of the currently hardcoded string.

Backpatched to 16 from the development branch to keep the code in
sync across branches.

Reviewed-by: Álvaro Herrera <alvherre@alvh.no-ip.org>
Discussion: https://postgr.es/m/CA+HiwqHu58pO3cJ7rB6ZLwUztVdG1J66xSjDdjfan5uT5NhESw@mail.gmail.com

Branch
------
REL_16_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/7825a1b01e400434835253b4ff38dd96d823d454

Modified Files
--------------
src/backend/parser/parse_expr.c | 24 +++++++++++++-----------
1 file changed, 13 insertions(+), 11 deletions(-)



^ permalink  raw  reply  [nested|flat] 4+ messages in thread


end of thread, other threads:[~2023-07-20 08:15 UTC | newest]

Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2023-07-13 03:33 pgsql: Pass constructName to transformJsonValueExpr() Amit Langote <amitlan@postgresql.org>
2023-07-13 04:08 ` Tom Lane <tgl@sss.pgh.pa.us>
2023-07-13 13:41   ` Amit Langote <amitlangote09@gmail.com>
2023-07-20 08:15 pgsql: Pass constructName to transformJsonValueExpr() Amit Langote <amitlan@postgresql.org>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox