pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Daniel Gustafsson <dgustafsson@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: pg_upgrade: include additional detail in cluster check
Date: Thu, 20 Jul 2023 13:10:01 +0000
Message-ID: <E1qMTPs-000RpX-DR@gemulon.postgresql.org> (raw)

pg_upgrade: include additional detail in cluster check

When the cluster failed the pg_controldata check for clean shut
down we only reported that it did so, not why. The state of the
cluster can be important information when diagnosing the failed
upgrade attempt, so instead include it in the error message.

Discussion: https://postgr.es/m/E0D5EA16-A085-4753-8DDC-C7055048B439@yesql.se

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/a3f695e645d0363d845a828db45deac5af1b4c0e

Modified Files
--------------
src/bin/pg_upgrade/controldata.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)



Message-ID: <E1qMTPs-000RpX-DR@gemulon.postgresql.org>
Permalink:  ../E1qMTPs-000RpX-DR@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qMTPs-000RpX-DR@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: dgustafsson@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: pg_upgrade: include additional detail in cluster check
  In-Reply-To: <E1qMTPs-000RpX-DR@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox