pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Amit Langote <amitlan@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Code review for commit b6e1157e7d
Date: Fri, 21 Jul 2023 10:29:37 +0000
Message-ID: <E1qMnOC-000ax7-HS@gemulon.postgresql.org> (raw)

Code review for commit b6e1157e7d

b6e1157e7d made some changes to enforce that
JsonValueExpr.formatted_expr is always set and is the expression that
gives a JsonValueExpr its runtime value, but that's not really
apparent from the comments about and the code manipulating
formatted_expr.  This commit fixes that.

Per suggestion from Álvaro Herrera.

Discussion: https://postgr.es/m/20230718155313.3wqg6encgt32adqb%40alvherre.pgsql

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/7c7412cae3ea8f8accdec1022969a9360b74f253

Modified Files
--------------
src/backend/nodes/makefuncs.c   | 11 ++++-------
src/backend/nodes/nodeFuncs.c   |  4 +---
src/backend/parser/gram.y       |  4 +++-
src/backend/parser/parse_expr.c | 17 +++++++++++------
src/include/nodes/makefuncs.h   |  3 ++-
src/include/nodes/primnodes.h   |  5 +++--
6 files changed, 24 insertions(+), 20 deletions(-)



Message-ID: <E1qMnOC-000ax7-HS@gemulon.postgresql.org>
Permalink:  ../E1qMnOC-000ax7-HS@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qMnOC-000ax7-HS@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: amitlan@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Code review for commit b6e1157e7d
  In-Reply-To: <E1qMnOC-000ax7-HS@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox