pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Compare only major versions in AdjustUpgrade.pm
Date: Mon, 24 Jul 2023 15:23:18 +0000
Message-ID: <E1qNxP3-0017ZD-F8@gemulon.postgresql.org> (raw)

Compare only major versions in AdjustUpgrade.pm

Because PostgreSQL::Version is very nuanced about development version
numbers, the comparison to 16beta2 makes it think that that release is
older than 16, therefore applying a database tweak that doesn't work
there (the comparison is only supposed to match when run on version 15).
As suggested by Andrew Dunstan, fix by having AdjustUpgrade.pm public
methods create a separate PostgreSQL::Version object to use for these
comparisons, that only carries the major version number.

While at it, have the same methods ensure that the objects given are of
the expected type.

Backpatch to 16.  This module goes all the way back to 9.2, but there's
probably no need for this fix except where betas still live.

Co-authored-by: Andrew Dunstan <andrew@dunslane.net>
Discussion: https://postgr.es/m/20230719110504.zbu74o54bqqlsufb@alvherre.pgsql

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/6061adedf53cbe0f94a52dd02465abf8c7c9fb43

Modified Files
--------------
src/test/perl/PostgreSQL/Test/AdjustUpgrade.pm | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)



view thread (2+ messages)  latest in thread

Message-ID: <E1qNxP3-0017ZD-F8@gemulon.postgresql.org>
Permalink:  ../E1qNxP3-0017ZD-F8@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qNxP3-0017ZD-F8@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: alvherre@alvh.no-ip.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Compare only major versions in AdjustUpgrade.pm
  In-Reply-To: <E1qNxP3-0017ZD-F8@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox