pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Amit Kapila <akapila@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix the display of UNKNOWN message type in apply worker.
Date: Tue, 25 Jul 2023 03:52:32 +0000
Message-ID: <E1qO967-001DLd-Rv@gemulon.postgresql.org> (raw)

Fix the display of UNKNOWN message type in apply worker.

We include the message type while displaying an error context in the
apply worker. Now, while retrieving the message type string if the
message type is unknown we throw an error that will hide the original
error. So, instead, we need to simply return the string indicating an
unknown message type.

Reported-by: Ashutosh Bapat
Author: Euler Taveira, Amit Kapila
Reviewed-by: Ashutosh Bapat
Backpatch-through: 15
Discussion: https://postgr.es/m/CAExHW5suAEDW-mBZt_qu4RVxWZ1vL54-L+ci2zreYWebpzxYsA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d38ad8e31dee1a69f4f6d4b6bb4e007e3751a93c

Modified Files
--------------
src/backend/replication/logical/proto.c  | 13 ++++++++++---
src/backend/replication/logical/worker.c |  2 +-
src/include/replication/logicalproto.h   |  2 +-
3 files changed, 12 insertions(+), 5 deletions(-)



view thread (5+ messages)  latest in thread

Message-ID: <E1qO967-001DLd-Rv@gemulon.postgresql.org>
Permalink:  ../E1qO967-001DLd-Rv@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qO967-001DLd-Rv@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: akapila@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix the display of UNKNOWN message type in apply worker.
  In-Reply-To: <E1qO967-001DLd-Rv@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox