pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Masahiko Sawada <msawada@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove unnecessary checks for indexes for REPLICA IDENTITY FULL
Date: Tue, 25 Jul 2023 06:13:14 +0000
Message-ID: <E1qOBIH-001EU1-GU@gemulon.postgresql.org> (raw)

Remove unnecessary checks for indexes for REPLICA IDENTITY FULL tables.

Previously, when selecting an usable index for update/delete for the
REPLICA IDENTITY FULL table, in IsIndexOnlyExpression(), we used to
check if all index fields are not expressions. However, it was not
necessary, because it is enough to check if only the leftmost index
field is not an expression (and references the remote table column)
and this check has already been done by
RemoteRelContainsLeftMostColumnOnIdx().

This commit removes IsIndexOnlyExpression() and
RemoteRelContainsLeftMostColumnOnIdx() and all checks for usable
indexes for REPLICA IDENTITY FULL tables are now performed by
IsIndexUsableForReplicaIdentityFull().

Backpatch this to remain the code consistent.

Reported-by: Peter Smith
Reviewed-by: Amit Kapila, Önder Kalacı
Discussion: https://postgr.es/m/CAHut%2BPsGRE5WSsY0jcLHJEoA17MrbP9yy8FxdjC_ZOAACxbt%2BQ%40mail.gmail.com
Backpatch-through: 16

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d0ce9d0bc7f6aab6e45158bfa4f19cffdd7079a6

Modified Files
--------------
src/backend/executor/execReplication.c     |   9 ---
src/backend/replication/logical/relation.c | 118 +++++++++++------------------
src/backend/replication/logical/worker.c   |  24 ++++--
src/include/replication/logicalrelation.h  |   2 +-
4 files changed, 64 insertions(+), 89 deletions(-)



view thread (2+ messages)

Message-ID: <E1qOBIH-001EU1-GU@gemulon.postgresql.org>
Permalink:  ../E1qOBIH-001EU1-GU@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qOBIH-001EU1-GU@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: msawada@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Remove unnecessary checks for indexes for REPLICA IDENTITY FULL
  In-Reply-To: <E1qOBIH-001EU1-GU@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox