pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Document more assumptions of LWLock variable changes with WAL in
Date: Wed, 26 Jul 2023 03:07:43 +0000
Message-ID: <E1qOUsI-001Mwy-9G@gemulon.postgresql.org> (raw)

Document more assumptions of LWLock variable changes with WAL inserts

This commit adds a few comments about what LWLockWaitForVar() relies on
when a backend waits for a variable update on its LWLocks for WAL
insertions up to an expected LSN.

First, LWLockWaitForVar() does not include a memory barrier, relying on
a spinlock taken at the beginning of WaitXLogInsertionsToFinish().  This
was hidden behind two layers of routines in lwlock.c.  This assumption
is now documented at the top of LWLockWaitForVar(), and detailed at bit
more within LWLockConflictsWithVar().

Second, document why WaitXLogInsertionsToFinish() does not include
memory barriers, relying on a spinlock at its top, which is, per Andres'
input, fine for two different reasons, both depending on the fact that
the caller of WaitXLogInsertionsToFinish() is waiting for a LSN up to a
certain value.

This area's documentation and assumptions could be improved more in the
future, but at least that's a beginning.

Author: Bharath Rupireddy, Andres Freund
Reviewed-by: Michael Paquier
Discussion: https://postgr.es/m/CALj2ACVF+6jLvqKe6xhDzCCkr=rfd6upaGc3477Pji1Ke9G7Bg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/66d86d4201b3a4b05c6d7d1bf827d4b17aa44a06

Modified Files
--------------
src/backend/access/transam/xlog.c | 11 +++++++++++
src/backend/storage/lmgr/lwlock.c | 11 ++++++++---
2 files changed, 19 insertions(+), 3 deletions(-)



Message-ID: <E1qOUsI-001Mwy-9G@gemulon.postgresql.org>
Permalink:  ../E1qOUsI-001Mwy-9G@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qOUsI-001Mwy-9G@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Document more assumptions of LWLock variable changes with WAL in
  In-Reply-To: <E1qOUsI-001Mwy-9G@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox