pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: David Rowley <drowley@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix performance problem with new COPY DEFAULT code
Date: Thu, 27 Jul 2023 02:49:05 +0000
Message-ID: <E1qOr3o-001WiC-MJ@gemulon.postgresql.org> (raw)

Fix performance problem with new COPY DEFAULT code

9f8377f7a added code to allow COPY FROM insert a column's default value
when the input matches the DEFAULT string specified in the COPY command.

Here we fix some inefficient code which needlessly palloc0'd an array to
store if we should use the default value or input value for the given
column.  This array was being palloc0'd and pfree'd once per row.  It's
much more efficient to allocate this once and just reset the values once
per row.

Reported-by: Masahiko Sawada
Author: Masahiko Sawada
Discussion: https://postgr.es/m/CAD21AoDvDmUQeJtZrau1ovnT_smN940%3DKp6mszNGK3bq9yRN6g%40mail.gmail.com
Backpatch-through: 16, where 9f8377f7a was introduced.

Branch
------
REL_16_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/c1308ce2d9224f0ec08128ab35e161837f9a5105

Modified Files
--------------
src/backend/commands/copyfrom.c      | 1 +
src/backend/commands/copyfromparse.c | 4 +---
2 files changed, 2 insertions(+), 3 deletions(-)



view thread (2+ messages)

Message-ID: <E1qOr3o-001WiC-MJ@gemulon.postgresql.org>
Permalink:  ../E1qOr3o-001WiC-MJ@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qOr3o-001WiC-MJ@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: drowley@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix performance problem with new COPY DEFAULT code
  In-Reply-To: <E1qOr3o-001WiC-MJ@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox