From: Robert Haas <rhaas@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Add and use symbolic constants for tar header offsets and file t
Date: Tue, 01 Aug 2023 17:56:46 +0000
Message-ID: <E1qQtbw-000AUf-P6@gemulon.postgresql.org> (raw)
Add and use symbolic constants for tar header offsets and file types.
Because symbolic constants in a header file are better than magic
constants embedded in the code.
Patch by me, reviewed by Tom Lane, Dagfinn Ilmari Mannsåker, and
Tristan Partin.
Discussion: http://postgr.es/m/CA+TgmoZNbLwhmCrNtkJAvi8FLkwFdMeVU3myV2HQQpA5bvbRZg@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/6050b6a92d1e6b5a234e96382ea711683e67d280
Modified Files
--------------
src/bin/pg_basebackup/bbstreamer_tar.c | 22 +++++++++----------
src/bin/pg_basebackup/walmethods.c | 7 +++---
src/bin/pg_dump/pg_backup_tar.c | 16 +++++++-------
src/include/pgtar.h | 39 ++++++++++++++++++++++++++++++++++
src/port/tar.c | 38 ++++++++++++++++-----------------
5 files changed, 80 insertions(+), 42 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: rhaas@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Add and use symbolic constants for tar header offsets and file t
In-Reply-To: <E1qQtbw-000AUf-P6@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox