pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: David Rowley <drowley@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix performance regression in pg_strtointNN_safe functions
Date: Wed, 02 Aug 2023 00:06:26 +0000
Message-ID: <E1qQzNh-0001uI-Av@gemulon.postgresql.org> (raw)

Fix performance regression in pg_strtointNN_safe functions

Between 6fcda9aba and 1b6f632a3, the pg_strtoint functions became quite
a bit slower in v16, despite efforts in 6b423ec67 to speed these up.

Since the majority of cases for these functions will only contain
base-10 digits, perhaps prefixed by a '-', it makes sense to have a
special case for this and just fall back on the more complex version
which processes hex, octal, binary and underscores if the fast path
version fails to parse the string.

While we're here, update the header comments for these functions to
mention that hex, octal and binary formats along with underscore
separators are now supported.

Author: Andres Freund, David Rowley
Reported-by: Masahiko Sawada
Reviewed-by: Dean Rasheed, John Naylor
Discussion: https://postgr.es/m/CAD21AoDvDmUQeJtZrau1ovnT_smN940%3DKp6mszNGK3bq9yRN6g%40mail.gmail.com
Backpatch-through: 16, where 6fcda9aba and 1b6f632a3 were added

Branch
------
REL_16_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/4e2e75cd29eb7bc591afe30fd7425629fe2c5a5d

Modified Files
--------------
src/backend/utils/adt/numutils.c | 306 +++++++++++++++++++++++++++++++++++----
1 file changed, 279 insertions(+), 27 deletions(-)



view thread (2+ messages)

Message-ID: <E1qQzNh-0001uI-Av@gemulon.postgresql.org>
Permalink:  ../E1qQzNh-0001uI-Av@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qQzNh-0001uI-Av@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: drowley@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix performance regression in pg_strtointNN_safe functions
  In-Reply-To: <E1qQzNh-0001uI-Av@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox