pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: David Rowley <drowley@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix misleading comment in paraminfo_get_equal_hashops
Date: Mon, 07 Aug 2023 06:17:32 +0000
Message-ID: <E1qStYZ-000pK3-8p@gemulon.postgresql.org> (raw)

Fix misleading comment in paraminfo_get_equal_hashops

The comment mistakenly claimed the code was checking PlaceHolderVars for
volatile functions when the code was actually checking lateral vars.

Update the comment to reflect the reality of the code.

Author: Richard Guo
Discussion: https://postgr.es/m/CAMbWs48HZGZOV85g0fx8z1qDx6NNKHexJPT2FCnKnZhxBWkd-A@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/fdd79d8992d600d38eecfab568b27f6d04e4dfb3

Modified Files
--------------
src/backend/optimizer/path/joinpath.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



Message-ID: <E1qStYZ-000pK3-8p@gemulon.postgresql.org>
Permalink:  ../E1qStYZ-000pK3-8p@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qStYZ-000pK3-8p@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: drowley@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix misleading comment in paraminfo_get_equal_hashops
  In-Reply-To: <E1qStYZ-000pK3-8p@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox