pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Improve const use in zlib-using code
Date: Mon, 07 Aug 2023 07:41:27 +0000
Message-ID: <E1qSurm-000q3r-8x@gemulon.postgresql.org> (raw)

Improve const use in zlib-using code

If we define ZLIB_CONST before including zlib.h, zlib augments some
interfaces with const decorations.  By doing that we can keep our own
interfaces cleaner and can remove some unconstify calls.

ZLIB_CONST was introduced in zlib 1.2.5.2 (17 Dec 2011).  When
compiling with older zlib releases, you might now get compiler
warnings about discarding qualifiers.

CentOS 6 has zlib 1.2.3, but in 8e278b6576, we removed support for the
OpenSSL release in CentOS 6, so it seems ok to de-support the zlib
release in CentOS 6 as well.

Reviewed-by: Tristan Partin <tristan@neon.tech>
Discussion: https://www.postgresql.org/message-id/flat/33462926-bb1e-7cc9-8d92-d86318e8ed1d%40eisentraut.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/67c0ef9752ade6dc252a19be8d2259847d4eb78d

Modified Files
--------------
contrib/pgcrypto/pgp-compress.c         | 2 +-
src/bin/pg_basebackup/bbstreamer_gzip.c | 2 +-
src/bin/pg_basebackup/walmethods.c      | 5 ++---
src/include/c.h                         | 5 +++++
4 files changed, 9 insertions(+), 5 deletions(-)



Message-ID: <E1qSurm-000q3r-8x@gemulon.postgresql.org>
Permalink:  ../E1qSurm-000q3r-8x@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qSurm-000q3r-8x@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Improve const use in zlib-using code
  In-Reply-To: <E1qSurm-000q3r-8x@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox