pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: ci: macos: Remove use of -Dsegsize_blocks=6
Date: Sat, 12 Aug 2023 22:12:33 +0000
Message-ID: <E1qUwqW-001l53-79@gemulon.postgresql.org> (raw)

ci: macos: Remove use of -Dsegsize_blocks=6

The option causes a measurable slowdown. Macos is, by far, the most expensive
platform for CI, therefore it doesn't make sense to run such a test there.

d3b111e3205 used a small segment size for two tasks, one with autoconf, one
with meson. In hindsight that is a bit overkill, it's unlikely that the option
would silently break. Thus don't move the -Dsegsize_blocks=6, just remove
it. I did however change the autoconf test to use 6 instead of 8 blocks, as
long as we allow it, a non-power-of-two test seems like a good idea.

While at it, add a comment explaining why we use a small segment size for CI.

Author: Andres Freund <andres@anarazel.de>
Reviewed-by: Heikki Linnakangas <hlinnaka@iki.fi>
Discussion: https://postgr.es/m/20230808021541.7lbzdefvma7qmn3w@awork3.anarazel.de
Backpatch: 16-, where d3b111e3205 introduced the use of -Dsegsize_blocks=6

Branch
------
REL_16_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/2243ef8dd6fbe1f4ae3ffc7db1ee9af9427ecadb

Modified Files
--------------
.cirrus.yml | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)



view thread (2+ messages)  latest in thread

Message-ID: <E1qUwqW-001l53-79@gemulon.postgresql.org>
Permalink:  ../E1qUwqW-001l53-79@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qUwqW-001l53-79@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: andres@anarazel.de, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: ci: macos: Remove use of -Dsegsize_blocks=6
  In-Reply-To: <E1qUwqW-001l53-79@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox