pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andrew Dunstan <andrew@dunslane.net>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Cache by-reference missing values in a long lived context
Date: Tue, 22 Aug 2023 19:17:54 +0000
Message-ID: <E1qYWt0-000Lym-6w@gemulon.postgresql.org> (raw)

Cache by-reference missing values in a long lived context

Attribute missing values might be needed past the lifetime of the tuple
descriptors from which they are extracted. To avoid possibly using
pointers for by-reference values which might thus be left dangling, we
cache a datumCopy'd version of the datum in the TopMemoryContext. Since
we first search for the value this only needs to be done once per
session for any such value.

Original complaint from Tom Lane, idea for mitigation by Andrew Dunstan,
tweaked by Tom Lane.

Backpatch to version 11 where missing values were introduced.

Discussion: https://postgr.es/m/1306569.1687978174@sss.pgh.pa.us

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/75f323aa1c1ec88f9781cb6d9307e42b820b26f0

Modified Files
--------------
src/backend/access/common/heaptuple.c | 90 ++++++++++++++++++++++++++++++++++-
src/tools/pgindent/typedefs.list      |  1 +
2 files changed, 90 insertions(+), 1 deletion(-)



view thread (15+ messages)  latest in thread

Message-ID: <E1qYWt0-000Lym-6w@gemulon.postgresql.org>
Permalink:  ../E1qYWt0-000Lym-6w@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qYWt0-000Lym-6w@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: andrew@dunslane.net, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Cache by-reference missing values in a long lived context
  In-Reply-To: <E1qYWt0-000Lym-6w@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox