pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Jeff Davis <jdavis@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix pg_dump assertion failure when dumping pg_catalog.
Date: Tue, 22 Aug 2023 20:08:17 +0000
Message-ID: <E1qYXfk-000MI1-Ql@gemulon.postgresql.org> (raw)

Fix pg_dump assertion failure when dumping pg_catalog.

Commit 396d348b04 did not account for the default collation.

Also, use pg_log_warning() instead of Assert().

Discussion: https://postgr.es/m/ce071503fee88334aa70f360e6e4ea14d48305ee.camel%40j-davis.com
Reviewed-by: Michael Paquier
Backpatch-through: 15

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/37188cea0c16f3f27ec65b526ffe12f6469142fc

Modified Files
--------------
src/bin/pg_dump/pg_dump.c        | 69 ++++++++++++++++++++++++++++++----------
src/bin/pg_dump/t/002_pg_dump.pl |  8 +++++
2 files changed, 61 insertions(+), 16 deletions(-)



view thread (6+ messages)  latest in thread

Message-ID: <E1qYXfk-000MI1-Ql@gemulon.postgresql.org>
Permalink:  ../E1qYXfk-000MI1-Ql@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qYXfk-000MI1-Ql@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: jdavis@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix pg_dump assertion failure when dumping pg_catalog.
  In-Reply-To: <E1qYXfk-000MI1-Ql@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox