pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Avoid use of Perl getprotobyname
Date: Wed, 23 Aug 2023 19:01:23 +0000
Message-ID: <E1qYt6Z-000WTo-13@gemulon.postgresql.org> (raw)

Avoid use of Perl getprotobyname

getprotobyname returns undefined on some CI machines.  It's not clear
why.  The code overall still works, but it raises a warning.

In PostgreSQL C code, we always call socket() with 0 for the protocol
argument, so we should be able to do the same in Perl (since the Perl
documentation says that the arguments of the socket function are the
same as in C).  So do that, to avoid the issue.

Reviewed-by: Andrew Dunstan <andrew@dunslane.net>
Discussion: https://www.postgresql.org/message-id/flat/06f899fd-1826-05ab-42d6-adeb1fd5e200%40eisentraut.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/01226c682ce6cc130c1057fcd5b0f24b2b622d39

Modified Files
--------------
src/test/perl/PostgreSQL/Test/Cluster.pm | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)



Message-ID: <E1qYt6Z-000WTo-13@gemulon.postgresql.org>
Permalink:  ../E1qYt6Z-000WTo-13@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qYt6Z-000WTo-13@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Avoid use of Perl getprotobyname
  In-Reply-To: <E1qYt6Z-000WTo-13@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox