pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Tighten unit parsing in internal values
Date: Mon, 28 Aug 2023 05:28:02 +0000
Message-ID: <E1qaUnB-001ISZ-Ve@gemulon.postgresql.org> (raw)

Tighten unit parsing in internal values

Interval values now generate an error when the user has multiple
consecutive units or a unit without a value.  Previously, it was
possible to specify multiple units consecutively which is contrary to
what the documentation allows, so it was possible to finish with
confusing interval values.

This is a follow-up of the work done in 165d581f146b.

Author: Joseph Koshakow
Reviewed-by: Jacob Champion, Gurjeet Singh, Reid Thompson
Discussion: https://postgr.es/m/CAAvxfHd-yNO+XYnUxL=GaNZ1n+eE0V-oE0+-cC1jdjdU0KS3iw@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/617f9b7d4b10fec00a86802eeb34d7295c52d747

Modified Files
--------------
src/backend/utils/adt/datetime.c       | 12 ++++++++++++
src/test/regress/expected/interval.out |  9 +++++++++
src/test/regress/sql/interval.sql      |  4 ++++
3 files changed, 25 insertions(+)



Message-ID: <E1qaUnB-001ISZ-Ve@gemulon.postgresql.org>
Permalink:  ../E1qaUnB-001ISZ-Ve@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qaUnB-001ISZ-Ve@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Tighten unit parsing in internal values
  In-Reply-To: <E1qaUnB-001ISZ-Ve@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox