pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Rename logical_replication_mode to debug_logical_replication_str
Date: Tue, 29 Aug 2023 13:38:10 +0000
Message-ID: <E1qayv3-001X2e-RG@gemulon.postgresql.org> (raw)

Rename logical_replication_mode to debug_logical_replication_streaming

The logical_replication_mode GUC is intended for testing and debugging
purposes, but its current name may be misleading and encourage users to make
unnecessary changes.

To avoid confusion, renaming the GUC to a less misleading name
debug_logical_replication_streaming that casual users are less likely to mistakenly
assume needs to be modified in a regular logical replication setup.

Author: Hou Zhijie <houzj.fnst@cn.fujitsu.com>
Reviewed-by: Peter Smith <smithpb2250@gmail.com>
Discussion: https://www.postgresql.org/message-id/flat/d672d774-c44b-6fec-f993-793e744f169a%40eisentraut.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/63956bed7b10fb3bb5fe3f74250a33c9e226a921

Modified Files
--------------
doc/src/sgml/config.sgml                           | 12 ++++-----
.../replication/logical/applyparallelworker.c      |  2 +-
src/backend/replication/logical/reorderbuffer.c    | 30 +++++++++++-----------
src/backend/utils/misc/guc_tables.c                | 14 +++++-----
src/include/replication/reorderbuffer.h            | 10 ++++----
src/test/subscription/t/015_stream.pl              |  2 +-
src/test/subscription/t/016_stream_subxact.pl      |  2 +-
.../subscription/t/018_stream_subxact_abort.pl     |  4 +--
.../subscription/t/019_stream_subxact_ddl_abort.pl |  2 +-
src/test/subscription/t/023_twophase_stream.pl     |  4 +--
10 files changed, 41 insertions(+), 41 deletions(-)



view thread (2+ messages)  latest in thread

Message-ID: <E1qayv3-001X2e-RG@gemulon.postgresql.org>
Permalink:  ../E1qayv3-001X2e-RG@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qayv3-001X2e-RG@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Rename logical_replication_mode to debug_logical_replication_str
  In-Reply-To: <E1qayv3-001X2e-RG@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox