pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Correct ObjectProperty entry for transforms
Date: Thu, 31 Aug 2023 09:12:42 +0000
Message-ID: <E1qbdjG-001nWr-9b@gemulon.postgresql.org> (raw)

Correct ObjectProperty entry for transforms

There was some confusion in the ObjectProperty entry for transforms.
Some fields had values that were apparently meant for a different
field.  Also, some fields were not assigned, which is okay for most
fields, but not for all.  In particular, for .oid_catcache_id,
.name_catcache_id, and .objtype, zero is a valid value, so we need to
use -1 if not applicable.  It has apparently been like that from the
very beginning (commit cac7658205).  The faulty values were not
actually reachable, so it's not a big problem in practice, but we
should make it correct.

Discussion: https://www.postgresql.org/message-id/flat/75ae5875-3abc-dafc-8aec-73247ed41cde@eisentraut.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d7ceb41b9b84092517bbd7aa1ea6c446f023504e

Modified Files
--------------
src/backend/catalog/objectaddress.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)



Message-ID: <E1qbdjG-001nWr-9b@gemulon.postgresql.org>
Permalink:  ../E1qbdjG-001nWr-9b@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qbdjG-001nWr-9b@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Correct ObjectProperty entry for transforms
  In-Reply-To: <E1qbdjG-001nWr-9b@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox